From patchwork Tue Dec 19 00:58:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 46100 Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR6Ff-0007u7-Jv; Tue, 19 Dec 2017 00:59:23 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935624AbdLSA7T (ORCPT + 1 other); Mon, 18 Dec 2017 19:59:19 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:39660 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933276AbdLSA7S (ORCPT ); Mon, 18 Dec 2017 19:59:18 -0500 Received: by mail-qk0-f194.google.com with SMTP id u184so20671836qkd.6 for ; Mon, 18 Dec 2017 16:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=WP4oBK7Cg4PGCdfjIAlaCytUHeza42S1EPEfpvQX1WQ=; b=Uv8Npw5QU7X5u//M89j4/fymFQC6v5j7gLebJ1U7VPtXkClnLU7yPbfqU2nzG6Pl2I vLLD7aQSs1rOkYmRyvgS4UrsnqElXTJj+TNr2FB68+e0bpwUqkEF5LqY6nL5oZVVb7Ae ayIEqDjjQxc0phqLjHnHvMiQahezbE2l1rQh8ddFBIds7q/GuU2xMJVefYFmRi3bBiKO Fp6GcKNjg5sJ8TrgLEfpZ6zibj23sH37Ft0Cojt9pHq+UlvCg1HYrmZ5LheKMnj95Tn5 xp8MJGU6GYsGuxXMmmxvuAYCpW1fKnQYfFiwqXp3luALT+ASkRH6DioclsVzGQihLC8w yDbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WP4oBK7Cg4PGCdfjIAlaCytUHeza42S1EPEfpvQX1WQ=; b=rBWChoGqGp3AQqCfd+uAgL5KqVUA6z4cVWWVyTxZ7I5FumMl1svTlQSs9s5fZ8GO7G TTziY6ORhxzvWxgd3M5SLIFapXX9oa+zFJv4oT5EnixlHzEUfF9BnXI+1sU2dqdn1bgM q5gIJmwcFZM4UB4ZM6J35SIbvpkqOqJDY20IGP9uaYewoIV714kTufl7Sv4jXVTI1Mr2 A3Lz70FnhXUqFiqD22zRHuHpdyF7UifiuZKVD7y6oYroE+KaSVrlOFzOO+0cmFUVigbW FJ/m4h4NHlkLyQoKgwTJWBHVa1gK8LYbLA0pkWIuLNG2riNqzmn55Y97/JG+4Ixpy82w igpg== X-Gm-Message-State: AKGB3mLBp4+4Ma3U/ourFCjDlQQdVtGtUt0moZzk48yVJYL3SIvw6g8H DLse8k1Fj8kxcwRrtwjKuds= X-Google-Smtp-Source: ACJfBot8090OelP3P4joHJ2WnJ5nLyGdC3RW0XwfqZ/fHBTZRuyTmifaQcZWz1NFyx5/UtY45K+fGQ== X-Received: by 10.55.114.196 with SMTP id n187mr2528353qkc.200.1513645158078; Mon, 18 Dec 2017 16:59:18 -0800 (PST) Received: from localhost.localdomain ([187.180.183.104]) by smtp.gmail.com with ESMTPSA id u43sm9018994qtj.54.2017.12.18.16.59.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Dec 2017 16:59:17 -0800 (PST) From: Fabio Estevam To: p.zabel@pengutronix.de Cc: mchehab@kernel.org, hansverk@cisco.com, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH] [media] coda/imx-vdoa: Remove irq member from vdoa_data struct Date: Mon, 18 Dec 2017 22:58:44 -0200 Message-Id: <1513645124-5825-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Fabio Estevam The 'irq' member of the vdoa_data struct is only used inside probe, so there is no need for it. Use a local variable 'ret' instead. Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- drivers/media/platform/coda/imx-vdoa.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/coda/imx-vdoa.c b/drivers/media/platform/coda/imx-vdoa.c index 8eb3e0c..eec27d3 100644 --- a/drivers/media/platform/coda/imx-vdoa.c +++ b/drivers/media/platform/coda/imx-vdoa.c @@ -86,7 +86,6 @@ struct vdoa_data { struct device *dev; struct clk *vdoa_clk; void __iomem *regs; - int irq; }; struct vdoa_q_data { @@ -293,6 +292,7 @@ static int vdoa_probe(struct platform_device *pdev) { struct vdoa_data *vdoa; struct resource *res; + int ret; dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32)); @@ -316,12 +316,12 @@ static int vdoa_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); if (!res) return -EINVAL; - vdoa->irq = devm_request_threaded_irq(&pdev->dev, res->start, NULL, + ret = devm_request_threaded_irq(&pdev->dev, res->start, NULL, vdoa_irq_handler, IRQF_ONESHOT, "vdoa", vdoa); - if (vdoa->irq < 0) { + if (ret < 0) { dev_err(vdoa->dev, "Failed to get irq\n"); - return vdoa->irq; + return ret; } platform_set_drvdata(pdev, vdoa);