From patchwork Fri Aug 11 11:50:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Pietrasiewicz X-Patchwork-Id: 43149 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dg8SN-0003xv-I6; Fri, 11 Aug 2017 11:50:24 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbdHKLuT (ORCPT + 1 other); Fri, 11 Aug 2017 07:50:19 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:49423 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752643AbdHKLuP (ORCPT ); Fri, 11 Aug 2017 07:50:15 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OUI00ELLRJPAK30@mailout3.w1.samsung.com>; Fri, 11 Aug 2017 12:50:13 +0100 (BST) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170811115012eucas1p169625e906e27279bf4d8c4c4c82948e3~ZyFOkzgYZ0106601066eucas1p1q; Fri, 11 Aug 2017 11:50:12 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id 3B.A5.12907.3F99D895; Fri, 11 Aug 2017 12:50:12 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170811115011eucas1p263bb57512af4ce8cee995ecfe92067ca~ZyFN7PNHP0926109261eucas1p2l; Fri, 11 Aug 2017 11:50:11 +0000 (GMT) X-AuditID: cbfec7f1-f793a6d00000326b-bf-598d99f36d9f Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id E8.D7.18832.3F99D895; Fri, 11 Aug 2017 12:50:11 +0100 (BST) Received: from AMDC831.digital.local ([106.116.147.122]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OUI0027SRJH2750@eusync3.samsung.com>; Fri, 11 Aug 2017 12:50:11 +0100 (BST) From: Andrzej Pietrasiewicz To: linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Andrzej Pietrasiewicz , Jacek Anaszewski , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Mauro Carvalho Chehab , Thierry Escande , Krzysztof Kozlowski Subject: [PATCH 1/2] media: s5p-jpeg: don't overwrite result's "size" member Date: Fri, 11 Aug 2017 13:50:00 +0200 Message-id: <1502452201-17171-2-git-send-email-andrzej.p@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1502452201-17171-1-git-send-email-andrzej.p@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsWy7djP87pfZvZGGnTvY7SY9bKdxWLjjPWs Fre3bmCxOH9+A7vFpsfXWC16NmxltZhxfh+Txdojd9ktVj+rsOi/eonNgctjx90ljB47Z91l 99i0qpPNY/OSeo8t/UBe35ZVjB6fN8kFsEdx2aSk5mSWpRbp2yVwZdyZ9YWx4DRnxb8DzWwN jJM5uhg5OSQETCQ2PpzLBmGLSVy4tx7I5uIQEljKKNH6YQIrSEJI4DOjxPxFel2MHGANF4/k QoSXMUq0T1CAqG9gkjiw4CUjSIJNwFhi78EOMFtEIEvi9KRGJhCbWeAKk8TP9XogtrCAj8SV 491sIDNZBFQlXq0uAAnzCrhK7Pu4lwniHjmJk8cmg53AKeAmcXf6WxaQXRIC09kl+tc2skPc Iyux6QAzRL2LRO+iV+wQtrDEq+NboGwZic6Og0wQvZMZJTbc/AA1aDujxNpjJ1ghqqwlDh+/ yApxKJ/EpG3TmSEW8Ep0tAlBlHhIXHryFGqoo8S6pW+YIZ6/yihxtqmRcQKjzAJGhlWMIqml xbnpqcVGesWJucWleel6yfm5mxiBsX763/GPOxjfn7A6xCjAwajEw+txqCdSiDWxrLgy9xCj BAezkgjvrBm9kUK8KYmVValF+fFFpTmpxYcYpTlYlMR5baPaIoUE0hNLUrNTUwtSi2CyTByc Ug2MxS/WOPo+2Fq2z8B5o8fn1z1tzw03S8TZSV9YeJptysNAscCX8rcfSmjIFbL1sKRIibFf 2/A7Z4qyg1TR+VPLc2P8ptQtO+X423v7nVUtf4/5/bz3LOHag+clFi+3z3C78+S4sGPSW8vG 5usJvqmlMtHCpmUTPqy7khTGeLO/3fbp5M+O9w8KKLEUZyQaajEXFScCAA65SIPxAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xq7qfZ/ZGGrR1KFnMetnOYrFxxnpW i9tbN7BYnD+/gd1i0+NrrBY9G7ayWsw4v4/JYu2Ru+wWq59VWPRfvcTmwOWx4+4SRo+ds+6y e2xa1cnmsXlJvceWfiCvb8sqRo/Pm+QC2KPcbDJSE1NSixRS85LzUzLz0m2VQkPcdC2UFPIS c1NtlSJ0fUOClBTKEnNKgTwjAzTg4BzgHqykb5fglnFn1hfGgtOcFf8ONLM1ME7m6GLk4JAQ MJG4eCS3i5ETyBSTuHBvPRuILSSwhFHizEHLLkYuILuJSeLC5HvMIAk2AWOJvQc7GEFsEYEs icPzZzGDFDEL3GCSOPpxIhNIQljAR+LK8W42kAUsAqoSr1YXgIR5BVwl9n3cywSxTE7i5LHJ rCA2p4CbxN3pb1kgljUySkw8s4RpAiPvAkaGVYwiqaXFuem5xYZ6xYm5xaV56XrJ+bmbGIGB v+3Yz807GC9tDD7EKMDBqMTD63GoJ1KINbGsuDL3EKMEB7OSCO+sGb2RQrwpiZVVqUX58UWl OanFhxhNgY6ayCwlmpwPjMq8knhDE0NzS0MjYwsLcyMjJXFe9ctNkUIC6YklqdmpqQWpRTB9 TBycUg2MfYdOS064OjvPyPzASWXm+/FBBjpWZqvm/Zfi9j3w+fqy9hWTsrcsSZh8Y4OwnN7v K+uUecNtuWu9qqwWH0k7MMHNbKX190+GLDtYIvwO9vazfHivc/LvBv7Ootsb7x5xv+KgXbdy 9ende/Kjw4ItGo5JSn30vv7q0q8WgZaADY5/7CPXbVT5qsRSnJFoqMVcVJwIAHmyKVeSAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170811115011eucas1p263bb57512af4ce8cee995ecfe92067ca X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBQaWV0cmFzaWV3aWN6G1NSUE9MLUtlcm5lbCAo?= =?UTF-8?B?VFApG+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBUb21hc3ogUGlldHJhc2lld2ljehtTUlBPTC1L?= =?UTF-8?B?ZXJuZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2Fy?= =?UTF-8?B?ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170811115011eucas1p263bb57512af4ce8cee995ecfe92067ca X-RootMTR: 20170811115011eucas1p263bb57512af4ce8cee995ecfe92067ca References: <1502191352-11595-1-git-send-email-andrzej.p@samsung.com> <1502452201-17171-1-git-send-email-andrzej.p@samsung.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Originally the "size" member was modified in a local variable passed to s5p_jpeg_parse_hdr() but the member was not used by the caller, so it did not matter. After applying the patch media: s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue the unnecessary assignment caused the actually used "size" member of the passed structure to assume a meaningless value. Fixes: 6c96dbbc2aa9f5b4a ("[media] s5p-jpeg: add support for 5433") Fixes: 14a2de14dc0619bf9 ("media: s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue") Signed-off-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index 4cef4b8..c00e3a1 100644 --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c @@ -1264,7 +1264,7 @@ static bool s5p_jpeg_parse_hdr(struct s5p_jpeg_q_data *result, } result->sof = sof; result->sof_len = sof_len; - result->size = result->components = components; + result->components = components; return true; }