From patchwork Wed Apr 19 23:13:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Devin Heitmueller X-Patchwork-Id: 40913 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0yo8-0002sq-UY; Wed, 19 Apr 2017 23:14:44 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-7) with esmtp id 1d0yo6-0006BG-2e; Thu, 20 Apr 2017 01:14:44 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938402AbdDSXOj (ORCPT + 1 other); Wed, 19 Apr 2017 19:14:39 -0400 Received: from mail-qt0-f169.google.com ([209.85.216.169]:35000 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940330AbdDSXOf (ORCPT ); Wed, 19 Apr 2017 19:14:35 -0400 Received: by mail-qt0-f169.google.com with SMTP id y33so32524506qta.2 for ; Wed, 19 Apr 2017 16:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernellabs-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sJarfMPRzqO9p1nWYOmIaaOLAsisf3SAq+yXIxAxgUY=; b=xqfz2jnaMRab9X7BCf3TUdfs763vpbbG6EhNMG8vxitumCrWb/29DwUpWvg0133VwM SvdCbqTF8l7Khr3snfWJWhAmwkhnt0jcgKetcJZAjUltPaAVEAIg7xxTIWQuEzbG5K0j tcC4p6xc5lEqTY/wzYkqHug16Jm/V4of0T35txNpDibH6Amp/jbmOGiHLGG0iwLUKc0K x8ui8CM3pR/x44v0x/tO4XPDhv2fyON5iuYs7kgMizhfonBn+CZYBPkiCQ+N+m6JF9ws B6rfTbFLIGgMPLHFmOcTgrgTmubtE+O/KNn2SLNF/9CkUMis+ZbcbbiS/97wgafXay5D baOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sJarfMPRzqO9p1nWYOmIaaOLAsisf3SAq+yXIxAxgUY=; b=ooztvNQ+bDgDilX+at4tv9cPQlFMwj1OwzA1F0OyaWetjKWIO2NeGgiLFyqonxKAMS z4rRZj6PgNq2bTZ3LVjsqyc1D59tc2UebIPr75i9++4ndVd/W1lzYfNVhLpa3ZHeovnk SNBY+qmftVD3kQMf4XRgJ3IRdzX0pke5wc5KRHoHErxaqXp8WLAp+CYupQd6o/Y1cSG5 ntKMBYBh5opAx3ND9sjksppj32ZWRqk15AI3lRQki3ggqt2kwBk15izUUWcS/aZ/PVqj 1oVvLxmTy2oXfp4MlD2uvyIjfMdY5DXWY/rWlvanL4HUfdEqddvUQmRkZT8e6zK2kaxx ITfA== X-Gm-Message-State: AN3rC/7gkBhqp5HWY9HNByypQgjAyzaMdS2YYq4mzkNFOx4aVMpVxzWX vaUpIXoh6HJL4Pv3 X-Received: by 10.200.47.16 with SMTP id j16mr5071742qta.222.1492643664533; Wed, 19 Apr 2017 16:14:24 -0700 (PDT) Received: from localhost.localdomain (cpe-74-71-114-159.nyc.res.rr.com. [74.71.114.159]) by smtp.gmail.com with ESMTPSA id 123sm2951916qkm.22.2017.04.19.16.14.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Apr 2017 16:14:24 -0700 (PDT) From: Devin Heitmueller To: linux-media@vger.kernel.org Cc: Devin Heitmueller Subject: [PATCH 02/12] au8522: don't touch i2c master registers on au8522 Date: Wed, 19 Apr 2017 19:13:45 -0400 Message-Id: <1492643635-30823-3-git-send-email-dheitmueller@kernellabs.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1492643635-30823-1-git-send-email-dheitmueller@kernellabs.com> References: <1492643635-30823-1-git-send-email-dheitmueller@kernellabs.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.4.19.230617 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __FROM_DOMAIN_IN_ANY_CC2 0, __FROM_DOMAIN_IN_RCPT 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Some stray lines got inserted into the driver when I reverse engineered the I2C traffic (at the time I didn't know what the registers did). It turns up these registers muck with the onboard I2C master, which we don't use since we instead use the I2C gate. Remove the lines which can actually interfere with the operation of the bus. Signed-off-by: Devin Heitmueller --- drivers/media/dvb-frontends/au8522_decoder.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/dvb-frontends/au8522_decoder.c b/drivers/media/dvb-frontends/au8522_decoder.c index 12a5c2c..7811717 100644 --- a/drivers/media/dvb-frontends/au8522_decoder.c +++ b/drivers/media/dvb-frontends/au8522_decoder.c @@ -422,8 +422,6 @@ static void set_audio_input(struct au8522_state *state) au8522_writereg(state, AU8522_AUDIO_VOLUME_L_REG0F2H, 0x00); au8522_writereg(state, AU8522_AUDIO_VOLUME_R_REG0F3H, 0x00); au8522_writereg(state, AU8522_AUDIO_VOLUME_REG0F4H, 0x00); - au8522_writereg(state, AU8522_I2C_CONTROL_REG1_REG091H, 0x80); - au8522_writereg(state, AU8522_I2C_CONTROL_REG0_REG090H, 0x84); msleep(150); au8522_writereg(state, AU8522_SYSTEM_MODULE_CONTROL_0_REG0A4H, 0x00); msleep(10);