From patchwork Mon Mar 20 14:42:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Cox X-Patchwork-Id: 40197 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpyXh-0005Hb-Ma; Mon, 20 Mar 2017 14:44:17 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-6) with esmtp id 1cpyXf-0007rT-5A; Mon, 20 Mar 2017 15:44:17 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754036AbdCTOmw (ORCPT + 1 other); Mon, 20 Mar 2017 10:42:52 -0400 Received: from mga09.intel.com ([134.134.136.24]:44493 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753814AbdCTOmp (ORCPT ); Mon, 20 Mar 2017 10:42:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490020964; x=1521556964; h=subject:from:to:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=UYCAIg8uc1LWbBsrTZdKEPMdBRi375C4kKVADS6Q3Xg=; b=vo8LfzgbvoN+uMQko3TVXctGa/vm6+fm2dhEcZ/rJDWa86vL0948zXrs 0fB5kp5WB5royC5sxco0CQZEOeHcwg==; Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2017 07:42:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,194,1486454400"; d="scan'208";a="62684331" Received: from acox1-desk1.ger.corp.intel.com ([10.252.22.109]) by orsmga002.jf.intel.com with ESMTP; 20 Mar 2017 07:42:42 -0700 Subject: [PATCH 23/24] atomisp: remove a sysfs error message that can be used to log spam From: Alan Cox To: greg@kroah.com, linux-media@vger.kernel.org Date: Mon, 20 Mar 2017 14:42:41 +0000 Message-ID: <149002095116.17109.15579549438168736336.stgit@acox1-desk1.ger.corp.intel.com> In-Reply-To: <149002068431.17109.1216139691005241038.stgit@acox1-desk1.ger.corp.intel.com> References: <149002068431.17109.1216139691005241038.stgit@acox1-desk1.ger.corp.intel.com> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.3.20.143617 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, NO_URI_HTTPS 0, REFERENCES 0, __ANY_URI 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' Instead of logging this just report ERANGE as an error, which will give something close to the right user space report. The others of these were already removed by Dan Carpenter's patch. Signed-off-by: Alan Cox --- .../media/atomisp/pci/atomisp2/atomisp_drvfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c index 7f7c6d5..fcfe8d7 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c @@ -107,9 +107,7 @@ static ssize_t iunit_dbglvl_store(struct device_driver *drv, const char *buf, if (kstrtouint(buf, 10, &iunit_debug.dbglvl) || iunit_debug.dbglvl < 1 || iunit_debug.dbglvl > 9) { - dev_err(atomisp_dev, "%s setting %d value invalid, should be [1,9]\n", - __func__, iunit_debug.dbglvl); - return -EINVAL; + return -ERANGE; } atomisp_css_debug_set_dtrace_level(iunit_debug.dbglvl);