From patchwork Thu Jan 5 12:34:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 38913 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cP7Ft-0007lq-Nu; Thu, 05 Jan 2017 12:34:53 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-7) with esmtp id 1cP7Fh-0006Jk-2f; Thu, 05 Jan 2017 13:34:53 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033652AbdAEMeY (ORCPT + 1 other); Thu, 5 Jan 2017 07:34:24 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:50654 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031968AbdAEMeW (ORCPT ); Thu, 5 Jan 2017 07:34:22 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OJB00II4498O240@mailout1.w1.samsung.com> for linux-media@vger.kernel.org; Thu, 05 Jan 2017 12:34:20 +0000 (GMT) Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170105123419eucas1p2e97fb18b2ceb5790996177844762fb29~W4DhGHlvd1897218972eucas1p2U; Thu, 5 Jan 2017 12:34:19 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges5.samsung.com (EUCPMTA) with SMTP id 9C.62.10572.B4D3E685; Thu, 5 Jan 2017 12:34:19 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170105123418eucas1p1a71a62cac9e538fa2997a8db8772d249~W4Dgap4Jr0085500855eucas1p1m; Thu, 5 Jan 2017 12:34:18 +0000 (GMT) X-AuditID: cbfec7f5-f79676d00000294c-1d-586e3d4b4a9a Received: from eusync4.samsung.com ( [203.254.199.214]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id C9.0C.06573.14D3E685; Thu, 5 Jan 2017 12:34:09 +0000 (GMT) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OJB002RD495VN00@eusync4.samsung.com>; Thu, 05 Jan 2017 12:34:18 +0000 (GMT) From: Andrzej Hajda To: linux-media@vger.kernel.org, s.nawrocki@samsung.com Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Mauro Carvalho Chehab , David Binderman Subject: [PATCH] v4l: s5c73m3: fix negation operator Date: Thu, 05 Jan 2017 13:34:07 +0100 Message-id: <1483619647-11753-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsWy7djP87retnkRBv+eClncWneO1WLjjPWs Ft8PJlj0bNjKarH2yF12i2Wb/jBZHH7TzurA7vG45wybx6ZVnWwefVtWMXp83iQXwBLFZZOS mpNZllqkb5fAlXFxz3fGgmtsFdMb+pkaGK+zdjFyckgImEj8uHsSyhaTuHBvPVsXIxeHkMBS RokT7xtYIJzPjBLnPjexw3S8OtgPVbWMUaL7wAdGCOc/o8Tax1fAZrEJaEr83XyTDcQWETCX mLW4lwmkiFngEaPEwwOvGEESwkCjNj+4CjaWRUBVounCTqAiDg5eAWeJL6+EIbbJSdw818kM YnMKxEtseXudGWSOhMBzNonLp6+zgNRLCMhKbDrADFHvInHh7Es2CFtY4tXxLVBXy0hcntzN AtHbzSjxqf8EO4QzhVHi34cZUN3WEoePXwT7gFmAT2LStunMEAt4JTrahCBKPCQ+Tl4OtcBR YnLXAnaI7zcwSqyb1cQ4gVFmASPDKkaR1NLi3PTUYlO94sTc4tK8dL3k/NxNjMDIPf3v+Ncd jEuPWR1iFOBgVOLhvfEjJ0KINbGsuDL3EKMEB7OSCC+bTV6EEG9KYmVValF+fFFpTmrxIUZp DhYlcd49C66ECwmkJ5akZqemFqQWwWSZODilGhj1xGJeTX+eWMAffuDzJI/wqf13/8lziux1 2mPm7ujG6b/hw+J1508e27Tliktpvf3s5fYb/pbtt35pcydFKZ6//11D/WHdGbtFCr5mLP2x grHkYuSCU0VqtzSU1PVff7J1vakQv/zy256lj21/iiyelHfwW9XvLS8/MKxRatSaMWexULV6 a+gjJZbijERDLeai4kQAfnLx+dgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xa7qOtnkRBhsOSVrcWneO1WLjjPWs Ft8PJlj0bNjKarH2yF12i2Wb/jBZHH7TzurA7vG45wybx6ZVnWwefVtWMXp83iQXwBLlZpOR mpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZGaABB+cA92AlfbsE t4yLe74zFlxjq5je0M/UwHidtYuRk0NCwETi1cF+NghbTOLCvfVgtpDAEkaJCf8Tuhi5gOxG JonG2euYQRJsApoSfzffBCsSETCXmLW4lwmkiFngCaPE6pPLwRLCQFM3P7jKDmKzCKhKNF3Y CVTEwcEr4Czx5ZUwxDI5iZvnOsFmcgrES3St7WWEWBwncX3tGbYJjLwLGBlWMYqklhbnpucW G+kVJ+YWl+al6yXn525iBIbvtmM/t+xg7HoXfIhRgINRiYe34VtOhBBrYllxZe4hRgkOZiUR XjabvAgh3pTEyqrUovz4otKc1OJDjKZAN01klhJNzgfGVl5JvKGJobmloZGxhYW5kZGSOO/U D1fChQTSE0tSs1NTC1KLYPqYODilGhjXpN5z3J734u3f/1tPvzPuWd+jwP5/WduqmhmT7UK1 Q/Yfsip+eWB3yYT0CQK5jzrVe/zSq/mmxD+LbzgRyXTzpwujDEvK2eSHVg/W2h5+9DXnclfs 9ZkstcsdvAtSHY9eXBifGfy+zSp9z7nodP01WWHbz9t2Bhsph965OW/7/UdcUccPtzQrsRRn JBpqMRcVJwIAS2wnnXUCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170105123418eucas1p1a71a62cac9e538fa2997a8db8772d249 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170105123418eucas1p1a71a62cac9e538fa2997a8db8772d249 X-RootMTR: 20170105123418eucas1p1a71a62cac9e538fa2997a8db8772d249 References: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.11.22.93017 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' HTML_NO_HTTP 0.1, MULTIPLE_RCPTS 0.1, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CP_URI_IN_BODY 0, __FROM_DOMAIN_IN_ANY_TO2 0, __FROM_DOMAIN_IN_RCPT 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0' Bool values should be negated using logical operators. Using bitwise operators results in unexpected and possibly incorrect results. Reported-by: David Binderman Signed-off-by: Andrzej Hajda --- drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c b/drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c index 0a06033..2e71850 100644 --- a/drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c @@ -211,7 +211,7 @@ static int s5c73m3_3a_lock(struct s5c73m3 *state, struct v4l2_ctrl *ctrl) } if ((ctrl->val ^ ctrl->cur.val) & V4L2_LOCK_FOCUS) - ret = s5c73m3_af_run(state, ~af_lock); + ret = s5c73m3_af_run(state, !af_lock); return ret; }