From patchwork Fri Nov 11 13:40:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 38035 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5C4R-00022J-Ol; Fri, 11 Nov 2016 13:40:43 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-7) with esmtp id 1c5C4P-0001Kw-0k; Fri, 11 Nov 2016 14:40:43 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756538AbcKKNkc (ORCPT + 1 other); Fri, 11 Nov 2016 08:40:32 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:32930 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756506AbcKKNk2 (ORCPT ); Fri, 11 Nov 2016 08:40:28 -0500 Received: by mail-pf0-f195.google.com with SMTP id 144so2596997pfv.0 for ; Fri, 11 Nov 2016 05:40:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wCR+gxC6VmH+uLleNXJGLfJeJbn/bhT1ViqB3MuP91Y=; b=IPaHjKtgPLwYGjKmglbnaHrMeHlET/CYFZQcp2s60JKzZXol2Cl6R5H42rGNJFRXV+ rvvtJPkuZHvWHodFo/Kq7kRJJJW5RMg83Dz75sgtQ1ND6Wa40mtVOpqDUcRwBnIvuLmY WyRCsg2o1OLhDqi1AtN0FkawMWVO2SWFkToS2GkxOr6Iv2LwwvikvRYFXBiB7/vuz7Q7 TdG3pjqM8XeRXnDXoX7qnRDBVgGOrGOrchVvadeKoOqV6hTXkDous24Bacfe8WLobH4t t5IIiHsokDp4IxYqfOK7CMBRdvR8OrhX4m2gILlo4Za4G3HAeEO/6sRKwYKH4hrdk0wj Nfew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wCR+gxC6VmH+uLleNXJGLfJeJbn/bhT1ViqB3MuP91Y=; b=Yor+K9JkvacU2yNStp6xCV62XUxyQ7ItniPyd6bvpNT5uaempVRsLJIriS4n0VeeN4 lZr8EBQM94ZpgciQPXU25ih1cMqNI8btt4gb9JvsNQVYLLK3a71gyY5+zSuU8GM0vitn 3Jd5yPvUC4HcDuM3VSJC+Vc9gziirW8qSnM+7A+3KIQkaw6af7XN3+t28bMBUqUGQgu0 gMpgc8mZnf1ktuBvgFWt2crQ/Zsat+EmqgMpuNSVZLUqYlFjY1gmEqK1sCnN6EbXOx8f E/lwNJUYbGekm7o/B2GBzd8SA0KyqK14zEWI6ABqovqL3m1xa/HMSRBgjnXmwZNj4JvA Wfug== X-Gm-Message-State: ABUngvdCJtF2OAbtQTXWubHgxIVvaOCU72QBXmte0/RX2bwJ1J+fholCC/tY8dEx/2Fm/A== X-Received: by 10.99.178.89 with SMTP id t25mr44732080pgo.131.1478871628255; Fri, 11 Nov 2016 05:40:28 -0800 (PST) Received: from localhost.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id 89sm10369655pfi.70.2016.11.11.05.40.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Nov 2016 05:40:27 -0800 (PST) From: Wei Yongjun To: Songjun Wu , Mauro Carvalho Chehab Cc: Wei Yongjun , linux-media@vger.kernel.org Subject: [PATCH -next] [media] atmel-isc: fix error return code in atmel_isc_probe() Date: Fri, 11 Nov 2016 13:40:20 +0000 Message-Id: <1478871620-24274-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.11.11.133017 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __FROM_HAS_AT 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' From: Wei Yongjun Fix to return error code -ENODEV from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/platform/atmel/atmel-isc.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c index 8e25d3f..fa68fe9 100644 --- a/drivers/media/platform/atmel/atmel-isc.c +++ b/drivers/media/platform/atmel/atmel-isc.c @@ -1424,6 +1424,7 @@ static int atmel_isc_probe(struct platform_device *pdev) if (list_empty(&isc->subdev_entities)) { dev_err(dev, "no subdev found\n"); + ret = -ENODEV; goto unregister_v4l2_device; }