From patchwork Wed Sep 21 15:12:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 37215 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmjDh-0001Ww-2r; Wed, 21 Sep 2016 15:13:57 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-8) with esmtp id 1bmjDf-0008Dq-jM; Wed, 21 Sep 2016 17:13:56 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933064AbcIUPNe (ORCPT + 1 other); Wed, 21 Sep 2016 11:13:34 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36849 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757579AbcIUPNc (ORCPT ); Wed, 21 Sep 2016 11:13:32 -0400 Received: by mail-pf0-f193.google.com with SMTP id n24so2507323pfb.3 for ; Wed, 21 Sep 2016 08:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Tq9vm6VwKMLXAUFglgGa3wpT3EMCGrWMmRKlST0nnlQ=; b=rhuCkAaOu5YJRzmS3sSyp59gfsZ4+ncmdtVTpEa/DV1G4vgx3jJG3AcMKkR2UEBKmR IwZQ30aWawMaEgKwinqNNgyKAtxB8ojXFMEnDLLBulJr5JYRtt0paqQ9ZvoOPdCi36Fv HRfNnD7qojbXqAKCt1wobsuJHClGe3nDZ3v9aagd67UIjtmKOYd4NjRzz/4OOK8lSYp4 sXT8A949cnS2NDbL7IYZmUEfzBlnRSlaoWVARDojQdGij2FG404I94BZaZ3B8S1Z9JHF D7MnmtcwIn1ZZI0s1Q2LKGy6LLYBF1/7G6HPW54BTBiFnp5iWbdZ5r6eqJuCbFW3s/Sv pm5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Tq9vm6VwKMLXAUFglgGa3wpT3EMCGrWMmRKlST0nnlQ=; b=MejZcYkDziqidFhIL/JOZtAr50w5lYQxc7tEaevWesDJVpeajisFNcBLd0f42iimw/ tutye7dtkaajJ4mcr1tFvuTst6rpYPZIVVimYNWytcOeegcsPdugtXUkOXudgfp02Iv6 FQcFWlilXqDMNxwTo/7Dp76Wvom6xwtsRIWk/eYreNhvoVHYKC8rBouUXItwkyTEHquv ksdzmVOcIE694VoMm3jLcOh1zQ+n9CS9QX8iYmX313MQT/B1gZ/9ik4FDOtBD69nw+s1 /BlRx/eSGlO9ds7ZzZ3MH5/AMB7LgpgyVliFKW9EpqnRMvhJdQX+YNVa4ITZ5Ba1gNwg kazg== X-Gm-Message-State: AE9vXwMfHB2xIjbIUH+MmFEYNcH0mvDWlWGStB3lLmbdH2uWNakaDBjuTwaLpfK22q6HFw== X-Received: by 10.98.217.70 with SMTP id s67mr45022090pfg.118.1474470785643; Wed, 21 Sep 2016 08:13:05 -0700 (PDT) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id nc13sm47487969pab.43.2016.09.21.08.13.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 08:13:05 -0700 (PDT) From: Wei Yongjun To: Mauro Carvalho Chehab , Junghak Sung , Julia Lawall , Hans Verkuil , Inki Dae , Geunyoung Kim , Seung-Woo Kim Cc: Wei Yongjun , linux-media@vger.kernel.org Subject: [PATCH -next] [media] cx88: fix error return code in cx8802_dvb_probe() Date: Wed, 21 Sep 2016 15:12:58 +0000 Message-Id: <1474470778-8469-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.9.21.150619 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_RCPTS_TO_X5 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' From: Wei Yongjun Fix to return error code -ENODEV from the error handling case instead of 0(err maybe overwrited to 0 in the for loop), as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/pci/cx88/cx88-dvb.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/pci/cx88/cx88-dvb.c b/drivers/media/pci/cx88/cx88-dvb.c index ac2392d..d76a175 100644 --- a/drivers/media/pci/cx88/cx88-dvb.c +++ b/drivers/media/pci/cx88/cx88-dvb.c @@ -1779,6 +1779,7 @@ static int cx8802_dvb_probe(struct cx8802_driver *drv) if (fe == NULL) { printk(KERN_ERR "%s() failed to get frontend(%d)\n", __func__, i); + err = -ENODEV; goto fail_probe; } q = &fe->dvb.dvbq;