From patchwork Thu Aug 4 08:31:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 36212 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVF2x-0004Sh-Jy; Thu, 04 Aug 2016 09:34:35 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-5) with esmtp id 1bVF2v-0001jn-8T; Thu, 04 Aug 2016 11:34:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932937AbcHDJeb (ORCPT + 1 other); Thu, 4 Aug 2016 05:34:31 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36013 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754207AbcHDJea (ORCPT ); Thu, 4 Aug 2016 05:34:30 -0400 Received: by mail-pf0-f194.google.com with SMTP id y134so17330338pfg.3 for ; Thu, 04 Aug 2016 02:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KWyEx1u4tWUsU/qzgipIJc4IWgJAtWF3PptpCpLLsxg=; b=ZagVIN/775LmS5tDehZqZ7R3D8JPuBwl2p1ZFeEE7OZRuGmt4TZTYmPwfC2DgCdFkw gqJotNKBZOqyrknDmddB0j7k8D6nQOr7s4zACVasOyXuK5bA/Mznd0XkqLbcaTVXJrfc UG3ZIEsNLsbjGyJ6QI3IwoJulN80YqKcPhIAqu0kV1IznTPWFhKZBqxXFEQV2269Dl14 96BLfRIvfH5uU/yLsBkb40Vrgvgg2aH1HD4v9+Swd6lzJ2RfVbL/LP8xAHoVfdtqQIsb W6xkJtaShuIZ2rirV5TzYdhblr80/+SCTeTEMxUAxW3ykmYjxbtwXwl73W0tjShqsQZa mm0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KWyEx1u4tWUsU/qzgipIJc4IWgJAtWF3PptpCpLLsxg=; b=Ydd5gdRiEv093pkDtjROCUW9k6kmPAkb89+LPhkwjyX26SmxAlYN1qcHAWv2RaCJFb bzVg3wi7xDnA0IT+iqNGA9V1vUikYFY5hlm9v7Jw8QOwwFSgY8RvX7ElHnOiAkwcFYPE q4Dfdylz7qQce4D858gdliq25JrKDQWrOpSpuzF2Gr2RmbNpjtoEbM7DFLnVuQHEQGfB dAwyG9RTTctEwZq31Zdor6qyJClaEFHvhCNpYuHUI4E7VbdJgEZKQFA0aZJ0gauR6pSW StKXcxQnBvdWwXodOf2zFNDhgvhx7jtvHUTAE7ViWpm59dCMLiDzRbcWFp2j/dt+sLpG eyTQ== X-Gm-Message-State: AEkooutXWfAPq/HpVQl8BVxjPFqODVc2JBo+9jp4DpeJwgHG0DWqXTZd5h3K9GjOX7ZIKw== X-Received: by 10.98.24.194 with SMTP id 185mr123597321pfy.52.1470299490944; Thu, 04 Aug 2016 01:31:30 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id xn11sm18185875pac.38.2016.08.04.01.31.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Aug 2016 01:31:29 -0700 (PDT) From: Wei Yongjun To: Hans Verkuil , Mauro Carvalho Chehab Cc: Wei Yongjun , linux-media@vger.kernel.org Subject: [PATCH -next] [media] adv7511: fix error return code in adv7511_probe() Date: Thu, 4 Aug 2016 08:31:22 +0000 Message-Id: <1470299482-23543-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.8.4.92416 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_DOMAIN_IN_ANY_CC2 0, __FROM_DOMAIN_IN_RCPT 0, __FROM_GMAIL 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' Fix to return error code -ENOMEM from the i2c client register error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/i2c/adv7511.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c index 53030d6..5ba0f21 100644 --- a/drivers/media/i2c/adv7511.c +++ b/drivers/media/i2c/adv7511.c @@ -1898,6 +1898,7 @@ static int adv7511_probe(struct i2c_client *client, const struct i2c_device_id * state->i2c_cec_addr >> 1); if (state->i2c_cec == NULL) { v4l2_err(sd, "failed to register cec i2c client\n"); + err = -ENOMEM; goto err_unreg_edid; } adv7511_wr(sd, 0xe2, 0x00); /* power up cec section */