From patchwork Sun May 29 10:04:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 34453 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b74iG-0006cH-LA; Sun, 29 May 2016 17:41:20 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-6) with esmtp id 1b74iE-0006IK-5P; Sun, 29 May 2016 19:41:20 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030179AbcE2Rkm (ORCPT + 1 other); Sun, 29 May 2016 13:40:42 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:54984 "EHLO baptiste.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752807AbcE2Rkl (ORCPT ); Sun, 29 May 2016 13:40:41 -0400 Received: from ayla.of.borg ([84.195.107.21]) by baptiste.telenet-ops.be with bizsmtp id 0Hge1t00l0TjorY01HgeYK; Sun, 29 May 2016 19:40:39 +0200 Received: from ramsan.of.borg ([192.168.97.29] helo=ramsan) by ayla.of.borg with esmtp (Exim 4.82) (envelope-from ) id 1b74ha-0006sy-7C; Sun, 29 May 2016 19:40:38 +0200 Received: from geert by ramsan with local (Exim 4.82) (envelope-from ) id 1b6xaC-0001hV-HL; Sun, 29 May 2016 12:04:32 +0200 From: Geert Uytterhoeven To: Mauro Carvalho Chehab Cc: Arnd Bergmann , linux-media@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH/RFC] [media] dvb-usb: Initialize ret in dvb_usb_adapter_frontend_init() Date: Sun, 29 May 2016 12:04:29 +0200 Message-Id: <1464516269-6504-1-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.5.29.173317 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, LEGITIMATE_NEGATE 0, MULTIPLE_RCPTS_RND 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __TO_MALFORMED_2 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0' drivers/media/usb/dvb-usb/dvb-usb-dvb.c: In function ‘dvb_usb_adapter_frontend_init’: drivers/media/usb/dvb-usb/dvb-usb-dvb.c:323: warning: ‘ret’ is used uninitialized in this function If num_frontends is zero, dvb_usb_adapter_frontend_init() will return an uninitialized value. Initialize ret to -ENODEV to fix this. Signed-off-by: Geert Uytterhoeven --- Can num_frontends ever be zero? drivers/media/usb/dvb-usb/dvb-usb-dvb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/dvb-usb-dvb.c b/drivers/media/usb/dvb-usb/dvb-usb-dvb.c index 6477b04e95c748cc..2ecc7009588a25a2 100644 --- a/drivers/media/usb/dvb-usb/dvb-usb-dvb.c +++ b/drivers/media/usb/dvb-usb/dvb-usb-dvb.c @@ -271,7 +271,7 @@ static int dvb_usb_fe_sleep(struct dvb_frontend *fe) int dvb_usb_adapter_frontend_init(struct dvb_usb_adapter *adap) { - int ret, i; + int ret = -ENODEV, i; /* register all given adapter frontends */ for (i = 0; i < adap->props.num_frontends; i++) {