From patchwork Thu Mar 24 11:23:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 33583 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aj3Nq-0003U5-KZ; Thu, 24 Mar 2016 11:24:58 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-7) with esmtp id 1aj3No-0002dF-22; Thu, 24 Mar 2016 12:24:58 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757334AbcCXLYN (ORCPT + 1 other); Thu, 24 Mar 2016 07:24:13 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:34943 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755882AbcCXLX6 (ORCPT ); Thu, 24 Mar 2016 07:23:58 -0400 Received: by mail-wm0-f41.google.com with SMTP id l68so232228677wml.0 for ; Thu, 24 Mar 2016 04:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5gyB3sTWs9WskunA8WAGtdnccGAEwtYZ4c6zsZwEYvI=; b=E/6OEcLHMRo10CzDv88dbKSgP94fX78+O5GoA+J2WeXtTj4Nbd+5MNna9UwE4SCejw 4DulIgbBM40mzWfWGZkV5Cusyb27UEePOS/XFuLNW3cMXGDOTQO6lAMAGn/9PlPd9rlS iCKG0LcvWkJIAbnyHmzxPFbRYxRmi6xQpVISc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5gyB3sTWs9WskunA8WAGtdnccGAEwtYZ4c6zsZwEYvI=; b=koHzdSkLXuhqFlObLgCwZ7xZZCZES082MpMLGFc5sbqrCx72MNMKx38ARJC17BU4bc KLRZfPLzLMnaNrqeLtCq0ssPuYYamg+W1dGuqTR7xp9e4kxcGdenbrPo7+c0FkhvNaFn DvZ9DUaRswJKx0Pn1jCF1ZPyWo1dHS2OcIXFOruq4uw53RuIilG/V2KIEMwD5bWMSRK/ GwUe74nw1A3FcV3hzFoCsYF+o5Yyv15IStGgT4jGAYrcfLg/uPipQVfPqSmfz8YsyZmX 3fUFys9YbCc0oZoDawKgPjyU/q6V5QVpG3692/2gTZR5nMqnhXbYBiuRNWMkRgFnDMLr 8yjg== X-Gm-Message-State: AD7BkJLdWH5zle/qnrBPPmfx0gQ1rf9MmPlXLwiWFaTIsT2s6is74U5laOxIu2ilAIUsSNoU X-Received: by 10.28.144.195 with SMTP id s186mr33415532wmd.9.1458818637301; Thu, 24 Mar 2016 04:23:57 -0700 (PDT) Received: from localhost.localdomain (cpc84787-aztw28-2-0-cust15.18-1.cable.virginm.net. [82.37.140.16]) by smtp.gmail.com with ESMTPSA id h7sm26519691wmf.9.2016.03.24.04.23.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 Mar 2016 04:23:56 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, mchehab@osg.samsung.com Cc: peter.griffin@linaro.org, lee.jones@linaro.org, hugues.fruchet@st.com, linux-media@vger.kernel.org Subject: [PATCH 1/3] [media] c8sectpfe: Fix broken circular buffer wp management Date: Thu, 24 Mar 2016 11:23:50 +0000 Message-Id: <1458818632-25552-2-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1458818632-25552-1-git-send-email-peter.griffin@linaro.org> References: <1458818632-25552-1-git-send-email-peter.griffin@linaro.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.3.24.111516 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_RCPTS_TO_X5 0, __REFERENCES 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' During the review process, a regression was intoduced in the circular buffer write pointer management. This means that wp doesn't get managed properly once the buffer becomes full. Signed-off-by: Peter Griffin --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c index 78e3cb9..875d384 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c @@ -130,7 +130,7 @@ static void channel_swdemux_tsklet(unsigned long data) writel(channel->back_buffer_busaddr, channel->irec + DMA_PRDS_BUSRP_TP(0)); else - writel(wp, channel->irec + DMA_PRDS_BUSWP_TP(0)); + writel(wp, channel->irec + DMA_PRDS_BUSRP_TP(0)); } static int c8sectpfe_start_feed(struct dvb_demux_feed *dvbdmxfeed)