From patchwork Wed Mar 16 11:04:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olli Salonen X-Patchwork-Id: 33486 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ag9GX-0000BW-UL; Wed, 16 Mar 2016 11:05:25 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-8) with esmtp id 1ag9GV-0000A2-mI; Wed, 16 Mar 2016 12:05:25 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966465AbcCPLFV (ORCPT + 1 other); Wed, 16 Mar 2016 07:05:21 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:34539 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965106AbcCPLFQ (ORCPT ); Wed, 16 Mar 2016 07:05:16 -0400 Received: by mail-lb0-f170.google.com with SMTP id k12so45317918lbb.1 for ; Wed, 16 Mar 2016 04:05:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IUI+kAatKr6Ele4SOTf9SbYvaWUSquGz/dwT5OgU+vw=; b=OHm0sS5CqYSbZTD2ffIjN3aHhJFfhUw+w4TJItXVFWsjnRnqeSPIHzKon5vw5h4ipi hZL+r/coa3WZ4Q72jRfeevmGtTt/5h5qpVyX8AjVW7TK+bC5K1P0ner2Ya8uV7v3fSoD 9cZwMYgG5uDwSwKxCZsFTTmwZLSra9QqsGFviXAPCxPsmz6IubA1VODvNhSGrJ+ht6ah RNzbCx8RUxRBG8z8vHarsPh/v5EehllwHHmQQlf0MK2JYVb+orv2Axn5XMDvfiezrfW2 PYYQYsO2hBJMXo+rJ0cmD5RHoXk4acDX0KNMdpqNT4r0X1BLZQPWCWfurjMKa2BCLnmG cEDw== X-Gm-Message-State: AD7BkJKwfz+VyfOjOVXeBoB9iiUmDEr8buq1ann8mwzFf9c7D8awXN5A+rAV72xrQ88Rnw== X-Received: by 10.112.62.229 with SMTP id b5mr485563lbs.30.1458126314526; Wed, 16 Mar 2016 04:05:14 -0700 (PDT) Received: from dl160.lan (178-55-1-76.bb.dnainternet.fi. [178.55.1.76]) by smtp.gmail.com with ESMTPSA id o1sm446184lbc.26.2016.03.16.04.05.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Mar 2016 04:05:13 -0700 (PDT) From: Olli Salonen To: linux-media@vger.kernel.org Cc: Olli Salonen Subject: [PATCHv2 2/2] ds3000: return error if invalid symbol rate is set Date: Wed, 16 Mar 2016 13:04:51 +0200 Message-Id: <1458126291-13914-2-git-send-email-olli.salonen@iki.fi> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1458126291-13914-1-git-send-email-olli.salonen@iki.fi> References: <1458126291-13914-1-git-send-email-olli.salonen@iki.fi> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.3.16.105715 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INFO_TLD 0, NO_URI_HTTPS 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __REFERENCES 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_NS_NXDOMAIN , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' Return -EINVAL if ds3000_set_frontend is called with invalid parameters. v1 of the patch series got incorrect subject lines. Signed-off-by: Olli Salonen --- drivers/media/dvb-frontends/ds3000.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/media/dvb-frontends/ds3000.c b/drivers/media/dvb-frontends/ds3000.c index addffc3..447b518 100644 --- a/drivers/media/dvb-frontends/ds3000.c +++ b/drivers/media/dvb-frontends/ds3000.c @@ -959,6 +959,15 @@ static int ds3000_set_frontend(struct dvb_frontend *fe) /* enable ac coupling */ ds3000_writereg(state, 0x25, 0x8a); + if ((c->symbol_rate < ds3000_ops.info.symbol_rate_min) || + (c->symbol_rate > ds3000_ops.info.symbol_rate_max)) { + dprintk("%s() symbol_rate %u out of range (%u ... %u)\n", + __func__, c->symbol_rate, + ds3000_ops.info.symbol_rate_min, + ds3000_ops.info.symbol_rate_max); + return -EINVAL; + } + /* enhance symbol rate performance */ if ((c->symbol_rate / 1000) <= 5000) { value = 29777 / (c->symbol_rate / 1000) + 1;