From patchwork Thu Sep 24 14:00:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 31523 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Zf7AH-000313-I2; Thu, 24 Sep 2015 16:06:25 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-7) with esmtp id 1Zf7AF-00015W-1P; Thu, 24 Sep 2015 16:06:25 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755865AbbIXOBo (ORCPT + 1 other); Thu, 24 Sep 2015 10:01:44 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61498 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755916AbbIXOBO (ORCPT ); Thu, 24 Sep 2015 10:01:14 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NV6006PWPM1RY70@mailout4.w1.samsung.com>; Thu, 24 Sep 2015 15:01:13 +0100 (BST) X-AuditID: cbfec7f4-f79c56d0000012ee-67-56040229a7b9 Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 49.2A.04846.92204065; Thu, 24 Sep 2015 15:01:13 +0100 (BST) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NV600IK6PLM8670@eusync4.samsung.com>; Thu, 24 Sep 2015 15:01:13 +0100 (BST) From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Laurent Pinchart , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH 06/19] staging: media: omap4iss: fix handling platform_get_irq result Date: Thu, 24 Sep 2015 16:00:14 +0200 Message-id: <1443103227-25612-7-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrELMWRmVeSWpSXmKPExsVy+t/xa7qaTCxhBlN+8lrcWneO1WLjjPWs FnvO/GK3aF68ns2ic+ISdovLu+awWfRs2MpqsfbIXXaL1c8qHDg97u07zOIxu2Mmq8f+uWvY Pbb032X36NuyitHj8ya5ALYoLpuU1JzMstQifbsEroypT+YzFvzlrOi8foqtgXExRxcjJ4eE gInEpG+bWSFsMYkL99azdTFycQgJLGWUOP5tETOE08QkMe/2SWaQKjYBTYm/m2+ygdgiAgoS m3ufgXUzCzxnkrjbZgViCwuES3yacY0FxGYRUJX4/XkZO4jNK+As8XfbbTaIbXISJ49NBuvl FHCReDt1ExOILQRUc+LILLYJjLwLGBlWMYqmliYXFCel5xrqFSfmFpfmpesl5+duYoSE3Jcd jIuPWR1iFOBgVOLhddBiDhNiTSwrrsw9xCjBwawkwsvxHijEm5JYWZValB9fVJqTWnyIUZqD RUmcd+6u9yFCAumJJanZqakFqUUwWSYOTqkGxlnPXKwym2vNKhWtX0cdOF/79EXBAxuGGrcc Rd25qfGt21TOmf6WeWwhZxZ6es3HL+V/4i5IpCdVFVeUud89Keb53dF04eMTrkU3tb48bZ0X 4mpX2cHp0JWwrUrn6pOdZzqOn/I/xLJ95tMVnkZGC8xfVxnE7XnkJPZnx7GHh+6vXfb5atn7 D0osxRmJhlrMRcWJALby+u81AgAA Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.9.24.135416 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' HTML_NO_HTTP 0.1, MULTIPLE_RCPTS 0.1, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1400_1499 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, NO_URI_HTTPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_URI_TEXT 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS ' The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/staging/media/omap4iss/iss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index 9bfb725..0b03cb7 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -1440,12 +1440,13 @@ static int iss_probe(struct platform_device *pdev) iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_REVISION)); /* Interrupt */ - iss->irq_num = platform_get_irq(pdev, 0); - if (iss->irq_num <= 0) { + ret = platform_get_irq(pdev, 0); + if (ret <= 0) { dev_err(iss->dev, "No IRQ resource\n"); ret = -ENODEV; goto error_iss; } + iss->irq_num = ret; if (devm_request_irq(iss->dev, iss->irq_num, iss_isr, IRQF_SHARED, "OMAP4 ISS", iss)) {