From patchwork Thu Sep 24 14:00:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 31522 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Zf7A6-0002yi-Ey; Thu, 24 Sep 2015 16:06:14 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-8) with esmtp id 1Zf7A4-0005qW-k1; Thu, 24 Sep 2015 16:06:14 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756784AbbIXOBp (ORCPT + 1 other); Thu, 24 Sep 2015 10:01:45 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61507 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755982AbbIXOBT (ORCPT ); Thu, 24 Sep 2015 10:01:19 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NV6007P7PM5QQ70@mailout4.w1.samsung.com>; Thu, 24 Sep 2015 15:01:18 +0100 (BST) X-AuditID: cbfec7f4-f79c56d0000012ee-7d-5604022de479 Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 3E.2A.04846.D2204065; Thu, 24 Sep 2015 15:01:17 +0100 (BST) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NV600IK6PLM8670@eusync4.samsung.com>; Thu, 24 Sep 2015 15:01:17 +0100 (BST) From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org Subject: [PATCH 10/19] cx231xx: fix handling cx231xx_read_i2c_data result Date: Thu, 24 Sep 2015 16:00:18 +0200 Message-id: <1443103227-25612-11-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42I5/e/4NV1dJpYwg8/PLC1urTvHarFxxnpW iyU/dzFZXN41h82iZ8NWVou1R+6yW6x+VuHA7jHl90ZWjy39d9k9+rasYvT4vEkugCWKyyYl NSezLLVI3y6BK+PLaceCpRwVa+cvYm9g/MHWxcjJISFgItG3/TALhC0mceHeeqA4F4eQwFJG if9bPzNBOE1MEl83tjGCVLEJaEr83XwTrFtEQEFic+8zVpAiZoF2JoknEzvBRgkLeEo0dywF s1kEVCUmn58M1swr4CJxb+cCdoh1chInj01mBbE5geJvp25iArGFBJwlThyZxTaBkXcBI8Mq RtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJBQ+rKDcfExq0OMAhyMSjy8DlrMYUKsiWXFlbmH GCU4mJVEeDneA4V4UxIrq1KL8uOLSnNSiw8xSnOwKInzzt31PkRIID2xJDU7NbUgtQgmy8TB KdXAqGFm/aooTMckaG6jz98EQcbpbf3x+826+l9dOl5vsiJI/0e5UGL7pZ+iOye/vORsaLVa ypqtLvjDYfaYotzb3OVM1q8cy59OdNBldWAVlfaVskltEe3ckxMiXX4obkHZ34rqv/tVVkhF 9E1k2DCl4I/XyhkfGxNTzvobR205aCwnKSrXK6nEUpyRaKjFXFScCAAkUJlkIQIAAA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.9.24.140016 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' HTML_NO_HTTP 0.1, MULTIPLE_RCPTS 0.1, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, NO_URI_HTTPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_URI_TEXT 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS ' The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/media/usb/cx231xx/cx231xx-video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c b/drivers/media/usb/cx231xx/cx231xx-video.c index 9798160..d0d8f08 100644 --- a/drivers/media/usb/cx231xx/cx231xx-video.c +++ b/drivers/media/usb/cx231xx/cx231xx-video.c @@ -1114,7 +1114,8 @@ int cx231xx_enum_input(struct file *file, void *priv, struct cx231xx_fh *fh = priv; struct cx231xx *dev = fh->dev; u32 gen_stat; - unsigned int ret, n; + unsigned int n; + int ret; n = i->index; if (n >= MAX_CX231XX_INPUT)