From patchwork Tue Aug 11 13:26:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacek Anaszewski X-Patchwork-Id: 30814 X-Patchwork-Delegate: sakari.ailus@iki.fi Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1ZP9ZU-0005WX-Dc; Tue, 11 Aug 2015 15:26:28 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-6) with esmtp id 1ZP9ZR-0006nK-6E; Tue, 11 Aug 2015 15:26:28 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934226AbbHKN0Y (ORCPT + 1 other); Tue, 11 Aug 2015 09:26:24 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:55205 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934066AbbHKN0X (ORCPT ); Tue, 11 Aug 2015 09:26:23 -0400 Received: from epcpsbgm1new.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NSX021876NXE000@mailout1.samsung.com> for linux-media@vger.kernel.org; Tue, 11 Aug 2015 22:26:21 +0900 (KST) X-AuditID: cbfee61a-f79a06d000005c6f-ab-55c9f7fdbe43 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id D2.70.23663.DF7F9C55; Tue, 11 Aug 2015 22:26:21 +0900 (KST) Received: from AMDC2362.DIGITAL.local ([106.120.53.23]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NSX002FN6NQ2B20@mmp1.samsung.com>; Tue, 11 Aug 2015 22:26:21 +0900 (KST) From: Jacek Anaszewski To: linux-media@vger.kernel.org Cc: Jacek Anaszewski , Hans Verkuil Subject: [PATCH] media: flash: Don't initialize core ops Date: Tue, 11 Aug 2015 15:26:12 +0200 Message-id: <1439299572-9293-1-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAJMWRmVeSWpSXmKPExsVy+t9jAd2/30+GGvT+NrFY8nMXk0Xv1eeM Fj0btrI6MHtM+b2R1aNvyypGj8+b5AKYo7hsUlJzMstSi/TtErgyjn//xFxwjaNi3+YXzA2M O9i7GDk5JARMJCY8aGKBsMUkLtxbz9bFyMUhJLCUUWLz2y2MEM5PRonVV18ygVSxCRhK/Hzx GswWEZCXeNJ7gw3EZhaIkPj8/TEriC0sYCFxfDdEPYuAqsTdCVOYQWxeAXeJ63dfA23mANqm IDFnks0ERu4FjAyrGCVSC5ILipPScw3zUsv1ihNzi0vz0vWS83M3MYL9/UxqB+PBXe6HGAU4 GJV4eAU8T4YKsSaWFVfmHmKU4GBWEuHlOA0U4k1JrKxKLcqPLyrNSS0+xCjNwaIkziu7YXOo kEB6YklqdmpqQWoRTJaJg1OqgbGZPzNU9uTru7zbn/SG3q3YX/C8K1b0fUR4UGTy3ndLomZ6 dbPn7V0tLbW4b/u2u4/YE/hy3dmuO36XX99ukpQ+0dp29iw3P+OUKA998S0KSUL+gaVFgnPM 5RrzT9wKq48OeCj5Nzq8vUhSbK/xJcXYMAFDm6pFW6a0ymbOy3z++rfp2afxSizFGYmGWsxF xYkAKUyPafMBAAA= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.8.11.131515 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS ' queryctrl and querymenu menu ops don't need to be initialized if sd.ctrl_handler is set. Since no other core ops are required by the wrapper don't initialize related field of v4l2_flash_subdev_ops. Signed-off-by: Jacek Anaszewski Cc: Hans Verkuil --- drivers/media/v4l2-core/v4l2-flash-led-class.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media/v4l2-core/v4l2-flash-led-class.c index 5bdfb8d..57a1829 100644 --- a/drivers/media/v4l2-core/v4l2-flash-led-class.c +++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c @@ -609,13 +609,7 @@ static const struct v4l2_subdev_internal_ops v4l2_flash_subdev_internal_ops = { .close = v4l2_flash_close, }; -static const struct v4l2_subdev_core_ops v4l2_flash_core_ops = { - .queryctrl = v4l2_subdev_queryctrl, - .querymenu = v4l2_subdev_querymenu, -}; - static const struct v4l2_subdev_ops v4l2_flash_subdev_ops = { - .core = &v4l2_flash_core_ops, }; struct v4l2_flash *v4l2_flash_init(