From patchwork Mon May 25 15:34:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 29826 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1YwuOm-00076K-PA; Mon, 25 May 2015 17:34:40 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-8) with esmtp id 1YwuOk-0001Fp-m1; Mon, 25 May 2015 17:34:40 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750771AbbEYPeg (ORCPT + 1 other); Mon, 25 May 2015 11:34:36 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:35278 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbbEYPee (ORCPT ); Mon, 25 May 2015 11:34:34 -0400 Received: by wgme6 with SMTP id e6so7195104wgm.2 for ; Mon, 25 May 2015 08:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XaWuGbHRTa0QDErn0Az+y69O6DeHAOSYAmndFM0IJfE=; b=zOK14yEtb9VIrxoywb9CfqwSbAE3M6dP+0vSn3nN2vPkhnrwNO9tamn6888+tfcKPP JIeNsNlFV5K/Kvtf1GHC82NkqnDw7Y1+z9CWy05t+1fIXQ0rV/lxKChukikUAG8suE+w VtqHy5a7FwUDERzCb6/LcprAn/jsGIy2cLwfNrBCLt2UY6WGmO+5t09qDe11a7HdEqvb q45vWZCr2zkcBG6okeNgEF0+B0N/cq/unMU9yY5MW6m1JXjcnsvZer+lSuU6U153xX2J HqnidbuWculerwhvdL7ks9CceRu4YRP1Ov8XNF2M8TjYUTgKZ3KRgKahSepF/n3IyL4R kRCQ== X-Received: by 10.180.11.196 with SMTP id s4mr22598352wib.43.1432568073269; Mon, 25 May 2015 08:34:33 -0700 (PDT) Received: from tango-charlie.Home ([94.1.38.236]) by mx.google.com with ESMTPSA id l6sm12404069wib.18.2015.05.25.08.34.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 May 2015 08:34:32 -0700 (PDT) From: Lad Prabhakar To: LMML , Hans Verkuil Cc: "Lad, Prabhakar" Subject: [PATCH 1/3] media: davinci_vpfe: clear the output_specs Date: Mon, 25 May 2015 16:34:27 +0100 Message-Id: <1432568069-11349-2-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1432568069-11349-1-git-send-email-prabhakar.csengg@gmail.com> References: <1432568069-11349-1-git-send-email-prabhakar.csengg@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.5.25.152416 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' FORGED_FROM_GMAIL 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1700_1799 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __PHISH_SPEAR_STRUCTURE_1 0, __REFERENCES 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: "Lad, Prabhakar" clear of the output_specs before passing it to the configure_resizer_out_params(), so that no garbage values are set. This fixes following build warning: drivers/staging/media/davinci_vpfe/dm365_resizer.c: In function 'resizer_set_stream': drivers/staging/media/davinci_vpfe/dm365_resizer.c:190:46: warning: 'output_specs.vst_c' may be used uninitialized in this function [-Wmaybe-uninitialized] param->ext_mem_param[index].rsz_sdr_ptr_s_c = output->vst_c; ^ drivers/staging/media/davinci_vpfe/dm365_resizer.c:316:30: note: 'output_specs.vst_c' was declared here struct vpfe_rsz_output_spec output_specs; ^ Signed-off-by: Lad, Prabhakar --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c index b649813..acb293e 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c +++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c @@ -321,6 +321,7 @@ static int resizer_configure_output_win(struct vpfe_resizer_device *resizer) outformat = &resizer->resizer_a.formats[RESIZER_PAD_SOURCE]; + memset(&output_specs, 0x0, sizeof(struct vpfe_rsz_output_spec)); output_specs.vst_y = param->user_config.vst; if (outformat->code == MEDIA_BUS_FMT_YDYUYDYV8_1X16) output_specs.vst_c = param->user_config.vst;