From patchwork Thu Apr 23 21:11:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olli Salonen X-Patchwork-Id: 29269 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1YlOPc-0006Me-HU; Thu, 23 Apr 2015 23:11:56 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-8) with esmtp id 1YlOPa-0007op-ky; Thu, 23 Apr 2015 23:11:56 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031265AbbDWVLq (ORCPT + 1 other); Thu, 23 Apr 2015 17:11:46 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:34583 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758415AbbDWVLd (ORCPT ); Thu, 23 Apr 2015 17:11:33 -0400 Received: by laat2 with SMTP id t2so21980859laa.1 for ; Thu, 23 Apr 2015 14:11:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=90OoozHMoOD78EDwfhSCnSFRVoSRqhAiZsbifwGb1z8=; b=YxTqWmxJYVxE6tJZTT1SRXrebFNqUvPZttTnL2kbRxMCRFrlwcgYoHs9B6JixPBSRK LZ8Lwgz3Y7izEBy9fB/5BeMy2kaRC++A7axT4Z5Pc0HGKY9Ht9MPQh5mBButvgSZwR4U SiioCF8lBsqXLhnZytYhZWaKsOhgrCZH3RsC0A339JmK/TZJph1X50ZgMMG2DIaBosSn EWW8DjKKIezivArPVINgKmZtIxcbsIMjskSZY5K2uaVLrm+jqeVx1+QtjDcc69jbyveK /w6YiWQ+XJVCRDq8j4iC7NV8c0WR8cFtyypnau9bbsArt83ZfdBNU9ftdagN37kydreo rlaA== X-Gm-Message-State: ALoCoQn9bKXHNEwGtOxfTbjw4gpjXOMD1XL9MQi9Tq0UxHHEREm15iUxuVMLC46DBgjXFuXejpmG X-Received: by 10.112.161.197 with SMTP id xu5mr4108353lbb.69.1429823491833; Thu, 23 Apr 2015 14:11:31 -0700 (PDT) Received: from dl160.lan (188-67-88-189.bb.dnainternet.fi. [188.67.88.189]) by mx.google.com with ESMTPSA id i3sm2121712lbs.21.2015.04.23.14.11.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Apr 2015 14:11:30 -0700 (PDT) From: Olli Salonen To: linux-media@vger.kernel.org Cc: Olli Salonen Subject: [PATCH 03/12] si2157: support selection of IF interface Date: Fri, 24 Apr 2015 00:11:02 +0300 Message-Id: <1429823471-21835-3-git-send-email-olli.salonen@iki.fi> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1429823471-21835-1-git-send-email-olli.salonen@iki.fi> References: <1429823471-21835-1-git-send-email-olli.salonen@iki.fi> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.4.23.210318 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __DATE_TZ_RU 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' The chips supported by the si2157 driver have two IF outputs (either pins 12+13 or pins 9+11). Instead of hardcoding the output to be used add an option to choose which output shall be used. Signed-off-by: Olli Salonen --- drivers/media/tuners/si2157.c | 4 +++- drivers/media/tuners/si2157.h | 6 ++++++ drivers/media/tuners/si2157_priv.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c index d74ae26..cdaf687 100644 --- a/drivers/media/tuners/si2157.c +++ b/drivers/media/tuners/si2157.c @@ -298,7 +298,8 @@ static int si2157_set_params(struct dvb_frontend *fe) if (dev->chiptype == SI2157_CHIPTYPE_SI2146) memcpy(cmd.args, "\x14\x00\x02\x07\x00\x01", 6); else - memcpy(cmd.args, "\x14\x00\x02\x07\x01\x00", 6); + memcpy(cmd.args, "\x14\x00\x02\x07\x00\x00", 6); + cmd.args[4] = dev->if_port; cmd.wlen = 6; cmd.rlen = 4; ret = si2157_cmd_execute(client, &cmd); @@ -378,6 +379,7 @@ static int si2157_probe(struct i2c_client *client, i2c_set_clientdata(client, dev); dev->fe = cfg->fe; dev->inversion = cfg->inversion; + dev->if_port = cfg->if_port; dev->fw_loaded = false; dev->chiptype = (u8)id->driver_data; dev->if_frequency = 5000000; /* default value of property 0x0706 */ diff --git a/drivers/media/tuners/si2157.h b/drivers/media/tuners/si2157.h index a564c4a..4db97ab 100644 --- a/drivers/media/tuners/si2157.h +++ b/drivers/media/tuners/si2157.h @@ -34,6 +34,12 @@ struct si2157_config { * Spectral Inversion */ bool inversion; + + /* + * Port selection + * Select the RF interface to use (pins 9+11 or 12+13) + */ + u8 if_port; }; #endif diff --git a/drivers/media/tuners/si2157_priv.h b/drivers/media/tuners/si2157_priv.h index cd8fa5b..71a5f8c 100644 --- a/drivers/media/tuners/si2157_priv.h +++ b/drivers/media/tuners/si2157_priv.h @@ -28,6 +28,7 @@ struct si2157_dev { bool fw_loaded; bool inversion; u8 chiptype; + u8 if_port; u32 if_frequency; };