From patchwork Thu Feb 26 18:19:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 28428 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1YR32N-00039G-H1; Thu, 26 Feb 2015 19:19:51 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1YR32L-00086W-3w; Thu, 26 Feb 2015 19:19:50 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754297AbbBZSTr (ORCPT + 1 other); Thu, 26 Feb 2015 13:19:47 -0500 Received: from mail-we0-f180.google.com ([74.125.82.180]:37691 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754264AbbBZSTq (ORCPT ); Thu, 26 Feb 2015 13:19:46 -0500 Received: by wesw55 with SMTP id w55so13482418wes.4 for ; Thu, 26 Feb 2015 10:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=8BVljChaDpvKQjWJaDK9QVHlsymc2fpu/T3wd8HwnUo=; b=x8Mipr+VKKkm47jM8DfS1u/IBLk37i/EHOibj2qkZ+sQSKE7ojdXMI9f8C5K16Y1vo jFaZRocwoSIrOd1MvJHR3H42fH+uOl9SaRtLcFgMfYrIpc8Cjw8qkxjoF5GpD3Z6yTO/ 5L1EC6L19B8eq3iT8sTnOvFDiFxJ9kb+Y1EBpJCs7kPzSFBXfMeDDfi/iWCx43UAl5ra vDSS2roQVoOO8DJ5VOqZPyr3JfEBz4gJpYhM0zzp7+c7eaDbMN9ZqD30t1+7vhx2qeHv DGfWMVFcDtJmrrJemUiCPvtFpB9b1a6pba50hx7XySn1jJC2vq116wW89/6r6/yTDkkH j8Bw== X-Received: by 10.194.77.230 with SMTP id v6mr19715726wjw.25.1424974785511; Thu, 26 Feb 2015 10:19:45 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id dx11sm2505879wjb.23.2015.02.26.10.19.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Feb 2015 10:19:44 -0800 (PST) From: Lad Prabhakar To: Lars-Peter Clausen Cc: linux-media@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH] media: i2c: adv7180: unregister the subdev in remove callback Date: Thu, 26 Feb 2015 18:19:29 +0000 Message-Id: <1424974769-27095-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.2.26.180918 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: "Lad, Prabhakar" this patch makes sure we unregister the subdev by calling v4l2_device_unregister_subdev() on remove callback. Signed-off-by: Lad, Prabhakar --- drivers/media/i2c/adv7180.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index b75878c..734d84a 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -1270,6 +1270,7 @@ static int adv7180_remove(struct i2c_client *client) if (state->chip_info->flags & ADV7180_FLAG_MIPI_CSI2) i2c_unregister_device(state->csi_client); + v4l2_device_unregister_subdev(sd); mutex_destroy(&state->mutex); return 0;