From patchwork Wed Feb 25 11:53:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacek Anaszewski X-Patchwork-Id: 28399 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1YQaXk-00033T-Jz; Wed, 25 Feb 2015 12:54:20 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1YQaXh-0000nq-6K; Wed, 25 Feb 2015 12:54:20 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbbBYLyP (ORCPT + 1 other); Wed, 25 Feb 2015 06:54:15 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:46387 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbbBYLyP (ORCPT ); Wed, 25 Feb 2015 06:54:15 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NKB00FZCT2D7Q20@mailout4.samsung.com> for linux-media@vger.kernel.org; Wed, 25 Feb 2015 20:54:13 +0900 (KST) X-AuditID: cbfee61a-f79c06d000004e71-7c-54edb7e5b586 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id EC.B3.20081.5E7BDE45; Wed, 25 Feb 2015 20:54:13 +0900 (KST) Received: from AMDC2362.DIGITAL.local ([106.120.53.23]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NKB00DZ1T1U1B20@mmp1.samsung.com>; Wed, 25 Feb 2015 20:54:13 +0900 (KST) From: Jacek Anaszewski To: linux-media@vger.kernel.org Cc: Jacek Anaszewski Subject: [PATCH] s5p-jpeg: exynos3250: fix erroneous reset procedure Date: Wed, 25 Feb 2015 12:53:49 +0100 Message-id: <1424865229-31634-1-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEJMWRmVeSWpSXmKPExsVy+t9jAd2n29+GGEybqWTRe/U5o0XPhq2s DkwefVtWMXp83iQXwBTFZZOSmpNZllqkb5fAldE28TFrwXe2iuP/u1kaGN+ydjFyckgImEgc PHaZGcIWk7hwbz0biC0ksIhRYs6nwC5GLiC7nUniee9+sAY2AUOJny9eM4HYIgLyEk96b4A1 MAvoS5yeex0sLizgIrHj/hwwm0VAVeLoiy1gNbwCHhJPZrQzdjFyAC1TkJgzyWYCI/cCRoZV jKKpBckFxUnpuYZ6xYm5xaV56XrJ+bmbGME+fSa1g3Flg8UhRgEORiUe3gThNyFCrIllxZW5 hxglOJiVRHh/bX0bIsSbklhZlVqUH19UmpNafIhRmoNFSZxXyb4tREggPbEkNTs1tSC1CCbL xMEp1cBYpN0dxqjXsfl4gNZnlvB9CdPambe+PGNc8e//WcHgrSkRFbZzzAKF+ZYW7Eo/ONVm 1pHSp50Viw4f2JO1fN1+hvu/u9ymSJyPVb9nvuvZXaMZ3qo58vNWz0083SpwPt/49pXMj+5L Hqmcc/e3kpw5l3v793K2hFS79PnfM6Y1dFxg/3g884y/EktxRqKhFnNRcSIAhlACluUBAAA= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.2.25.114517 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' The first while loop in the function exynos3250_jpeg_reset had no chance to be executed because the reg variable was initialized to 0. Initialize reg variable to 1 to fix the issue. Signed-off-by: Jacek Anaszewski Reported-by: Andrzej Pietrasiewicz --- .../media/platform/s5p-jpeg/jpeg-hw-exynos3250.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c index e8c2cad..0974b9a 100644 --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c @@ -20,7 +20,7 @@ void exynos3250_jpeg_reset(void __iomem *regs) { - u32 reg = 0; + u32 reg = 1; int count = 1000; writel(1, regs + EXYNOS3250_SW_RESET);