From patchwork Mon Feb 23 20:19:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 28391 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1YPzVV-0005Ub-0x; Mon, 23 Feb 2015 21:21:33 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1YPzVS-0004E3-7d; Mon, 23 Feb 2015 21:21:32 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbbBWUVK (ORCPT + 1 other); Mon, 23 Feb 2015 15:21:10 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:52738 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbbBWUTk (ORCPT ); Mon, 23 Feb 2015 15:19:40 -0500 Received: by mail-wi0-f179.google.com with SMTP id ex7so135329wid.0; Mon, 23 Feb 2015 12:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Lbi5qg6NAS+MWNaCk37zX3fXjZEabcwfkCLHBNy22PI=; b=yQk+f9m+/H634IQSnd0/dYps5rAhR7a41VuMqFSkCg/ffcY8P22YwCXJBiOEiIVacX zpB8P6OJwSOWNXVCJlBfH9GX29izLKrASMbH3UnA25L4vg5BYyEEKSaAETBvszIYuma9 2RDHrwgLum91PykC7nIIfuNfd2O0eVMy4z4c6QGng8ubzsaDqku1MVNWIY+MiwEU4v6h cevdRbfu1fkdh6fk1Qxl2CYH8WH3SoV+1aqYBhL18f6lasFpfQaRVOSq6niQesBeEsTb 1yOhYfweeaDDAcGYrETNAqqISrU3XGQbcCexkyPp1MEFYlp4Xr7OAzm58U7yOmNTwUf8 uWOA== X-Received: by 10.180.84.166 with SMTP id a6mr23565991wiz.4.1424722779460; Mon, 23 Feb 2015 12:19:39 -0800 (PST) Received: from tango-charlie.Home (0545247b.skybroadband.com. [5.69.36.123]) by mx.google.com with ESMTPSA id bf8sm48103517wjb.37.2015.02.23.12.19.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Feb 2015 12:19:38 -0800 (PST) From: Lad Prabhakar To: Laurent Pinchart , Sakari Ailus Cc: LMML , LKML , "Lad, Prabhakar" Subject: [PATCH 1/3] media: omap3isp: ispvideo: drop setting of vb2 buffer state to VB2_BUF_STATE_ACTIVE Date: Mon, 23 Feb 2015 20:19:31 +0000 Message-Id: <1424722773-20131-2-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1424722773-20131-1-git-send-email-prabhakar.csengg@gmail.com> References: <1424722773-20131-1-git-send-email-prabhakar.csengg@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.2.23.201219 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __REFERENCES 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: "Lad, Prabhakar" There isn't a need to assign the state of vb2_buffer to active as this is already done by the core. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/omap3isp/ispvideo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index 3fe9047..837018d 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -524,7 +524,6 @@ struct isp_buffer *omap3isp_video_buffer_next(struct isp_video *video) buf = list_first_entry(&video->dmaqueue, struct isp_buffer, irqlist); - buf->vb.state = VB2_BUF_STATE_ACTIVE; spin_unlock_irqrestore(&video->irqlock, flags);