From patchwork Wed Feb 18 16:20:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacek Anaszewski X-Patchwork-Id: 28289 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1YO7No-0007aj-7M; Wed, 18 Feb 2015 17:21:52 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1YO7Nl-0000CB-mJ; Wed, 18 Feb 2015 17:21:51 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbbBRQVn (ORCPT + 1 other); Wed, 18 Feb 2015 11:21:43 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:62429 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbbBRQVl (ORCPT ); Wed, 18 Feb 2015 11:21:41 -0500 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJZ00K9X6S3SP30@mailout4.samsung.com>; Thu, 19 Feb 2015 01:21:39 +0900 (KST) X-AuditID: cbfee61b-f79d76d0000024d6-0c-54e4bc13e1a0 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 41.B3.09430.31CB4E45; Thu, 19 Feb 2015 01:21:39 +0900 (KST) Received: from AMDC2362.DIGITAL.local ([106.120.53.23]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NJZ003WS6QJDJ20@mmp1.samsung.com>; Thu, 19 Feb 2015 01:21:39 +0900 (KST) From: Jacek Anaszewski To: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Cc: kyungmin.park@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com, Jacek Anaszewski Subject: [PATCH/RFC v11 02/20] leds: flash: Improve sync strobe related sysfs attributes Date: Wed, 18 Feb 2015 17:20:23 +0100 Message-id: <1424276441-3969-3-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1424276441-3969-1-git-send-email-j.anaszewski@samsung.com> References: <1424276441-3969-1-git-send-email-j.anaszewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOLMWRmVeSWpSXmKPExsVy+t9jAV3hPU9CDG6sVbA4unMik8X8I+dY LXqvPme0ONv0ht1i65t1jBY9G7ayWtw9dZTNYveup6wWh9+0s1qc2b+SzYHLY+esu+weh78u ZPHYM/8Hq0ffllWMHitWf2f3+LxJLoAtissmJTUnsyy1SN8ugStj8sRr7AUHuCsW33/H3MB4 kLOLkZNDQsBE4uWMfYwQtpjEhXvr2boYuTiEBBYxSvydNIEFwmlnkrgy/zcLSBWbgKHEzxev mUBsEYFIiXdHLzGDFDELbGCUuDyhEaxIWCBK4unRo2wgNouAqsTUKXvAbF4Bd4mVf2YAreMA WqcgMWeSDYjJKeAhceG5B0iFEFDF9JvvWCcw8i5gZFjFKJpakFxQnJSea6RXnJhbXJqXrpec n7uJERx8z6R3MK5qsDjEKMDBqMTD2/D7cYgQa2JZcWXuIUYJDmYlEd7clU9ChHhTEiurUovy 44tKc1KLDzFKc7AoifMq2beFCAmkJ5akZqemFqQWwWSZODilGhiFJn841fNSaarxxH2NxoUz 9Xx0S/kXNc+xXcrf8GR617f0p0f/1L2pPNAlatR+QNI7bEr6w7mp3YdWVWdOXZKVV/R7Uebq R2vD6w/5CtyRlK29lf3I5pnZyiduTaZb9vZrSJh5sTwsyf1+fWrkt6If+YF1vdYrN+dYzWMS 2f9CuemBj5RknrgSS3FGoqEWc1FxIgBMS8mQOgIAAA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.2.18.161217 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1600_1699 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BADTHINGS 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' Current format of synchronized strobe related attributes introduces problems when it comes to parsing. Avoding the usage of square brackets and colons makes the parsing more convenient. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/led-class-flash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c index 4a19fd4..a2da52e 100644 --- a/drivers/leds/led-class-flash.c +++ b/drivers/leds/led-class-flash.c @@ -224,11 +224,11 @@ static ssize_t available_sync_leds_show(struct device *dev, char *pbuf = buf; int i, buf_len; - buf_len = sprintf(pbuf, "[0: none] "); + buf_len = sprintf(pbuf, "0.none "); pbuf += buf_len; for (i = 0; i < fled_cdev->num_sync_leds; ++i) { - buf_len = sprintf(pbuf, "[%d: %s] ", i + 1, + buf_len = sprintf(pbuf, "%d.%s ", i + 1, fled_cdev->sync_leds[i]->led_cdev.name); pbuf += buf_len; } @@ -281,7 +281,7 @@ static ssize_t flash_sync_strobe_show(struct device *dev, sync_led_name = (char *) fled_cdev->sync_leds[sled_id - 1]->led_cdev.name; - return sprintf(buf, "[%d: %s]\n", sled_id, sync_led_name); + return sprintf(buf, "%d.%s\n", sled_id, sync_led_name); } static DEVICE_ATTR_RW(flash_sync_strobe);