From patchwork Mon Jan 26 14:50:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 28050 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1YFl0A-0005AE-JU; Mon, 26 Jan 2015 15:50:54 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1YFl08-0007WO-8G; Mon, 26 Jan 2015 15:50:54 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754481AbbAZOuh (ORCPT + 1 other); Mon, 26 Jan 2015 09:50:37 -0500 Received: from mail-wg0-f50.google.com ([74.125.82.50]:51650 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754131AbbAZOud (ORCPT ); Mon, 26 Jan 2015 09:50:33 -0500 Received: by mail-wg0-f50.google.com with SMTP id b13so9371920wgh.9; Mon, 26 Jan 2015 06:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=7ypISmC2XuSErzceWg5jriNiXtkM0yWyPJquX1WpeR0=; b=CWVeas4JGJK7RkoD9vv16U92HzquiMNRuERTUZn988WlouIosAAHvFj5fX+gZ+5/Ry i55Tv6Wm6KXWb5+ZGJto+w+vi+UkzK91sStgjgU2PylfrotxBC1ST/ZRWMvy5bV2TaBm 0WI1zVKfuTmF5HBosNn8MqwWrVvd3vURioYDCfBxDoNKpcj1LWtW/rQH4o8Zkb/m6uA/ T+hADobRo4cOMPXy/d4c7fY8r3v63/2UEgtj5qtMUrV1yNUkeeauWFujOG0zf0H+ks42 q8/MDwk66MarKhMfsq/gk3Xiv/Hho0s+jDqPRb/wmeUw98VH1zVhZQa1/0kn3CzMLM8i oMxg== X-Received: by 10.180.89.210 with SMTP id bq18mr33260188wib.45.1422283831662; Mon, 26 Jan 2015 06:50:31 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id g10sm14239240wic.7.2015.01.26.06.50.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 26 Jan 2015 06:50:30 -0800 (PST) From: "Lad, Prabhakar" To: LMML , Hans Verkuil Cc: LKML , Mauro Carvalho Chehab , "Lad, Prabhakar" Subject: [PATCH] media: am437x: fix sparse warnings Date: Mon, 26 Jan 2015 14:50:15 +0000 Message-Id: <1422283815-1795-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.1.26.144223 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1900_1999 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' This patch fixes following spare warnings: drivers/media/platform/am437x/am437x-vpfe.c:66:28: warning: symbol 'vpfe_standards' was not declared. Should it be static? drivers/media/platform/am437x/am437x-vpfe.c:2202:57: warning: incorrect type in argument 2 (different address spaces) drivers/media/platform/am437x/am437x-vpfe.c:2202:57: expected void [noderef] *params drivers/media/platform/am437x/am437x-vpfe.c:2202:57: got void *param include/linux/spinlock.h:364:9: warning: context imbalance in 'vpfe_start_streaming' - unexpected unlock Reported-by: Fengguang Wu Signed-off-by: Lad, Prabhakar --- drivers/media/platform/am437x/am437x-vpfe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c index e01ac22..349bd06 100644 --- a/drivers/media/platform/am437x/am437x-vpfe.c +++ b/drivers/media/platform/am437x/am437x-vpfe.c @@ -63,7 +63,7 @@ struct vpfe_standard { int frame_format; }; -const struct vpfe_standard vpfe_standards[] = { +static const struct vpfe_standard vpfe_standards[] = { {V4L2_STD_525_60, 720, 480, {11, 10}, 1}, {V4L2_STD_625_50, 720, 576, {54, 59}, 1}, }; @@ -2024,7 +2024,6 @@ err: list_del(&buf->list); vb2_buffer_done(&buf->vb, VB2_BUF_STATE_QUEUED); } - spin_unlock_irqrestore(&vpfe->dma_queue_lock, flags); return ret; } @@ -2199,7 +2198,7 @@ static long vpfe_ioctl_default(struct file *file, void *priv, switch (cmd) { case VIDIOC_AM437X_CCDC_CFG: - ret = vpfe_ccdc_set_params(&vpfe->ccdc, param); + ret = vpfe_ccdc_set_params(&vpfe->ccdc, (void __user *)param); if (ret) { vpfe_dbg(2, vpfe, "Error setting parameters in CCDC\n");