From patchwork Mon Dec 8 20:31:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Larsson X-Patchwork-Id: 27395 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Xy4xi-0003Bm-SP; Mon, 08 Dec 2014 21:31:18 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1Xy4xg-00076A-2L; Mon, 08 Dec 2014 21:31:18 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbaLHUbM (ORCPT + 1 other); Mon, 8 Dec 2014 15:31:12 -0500 Received: from smtp.bredband2.com ([83.219.192.166]:34863 "EHLO smtp.bredband2.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754737AbaLHUbK (ORCPT ); Mon, 8 Dec 2014 15:31:10 -0500 Received: from localhost.localdomain (92-244-23-216.customers.ownit.se [92.244.23.216]) (Authenticated sender: ed8153) by smtp.bredband2.com (Postfix) with ESMTPA id D7B87105C06; Mon, 8 Dec 2014 21:31:07 +0100 (CET) From: Benjamin Larsson To: Antti Palosaari Cc: Linux Media Mailing List Subject: [PATCH 1/2] mn88472: fix firmware downloading Date: Mon, 8 Dec 2014 21:31:06 +0100 Message-Id: <1418070667-13349-1-git-send-email-benjamin@southpole.se> X-Mailer: git-send-email 2.1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.12.8.202119 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' The max amount of payload bytes in each i2c transfer when loading the demodulator firmware is 16 bytes. Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index ffee187..df7dbe9 100644 --- a/drivers/staging/media/mn88472/mn88472.c +++ b/drivers/staging/media/mn88472/mn88472.c @@ -15,6 +15,7 @@ */ #include "mn88472_priv.h" +#define FW_BUF_SIZE 16 static int mn88472_get_tune_settings(struct dvb_frontend *fe, struct dvb_frontend_tune_settings *s) @@ -331,10 +332,10 @@ static int mn88472_init(struct dvb_frontend *fe) goto err; for (remaining = fw->size; remaining > 0; - remaining -= (dev->i2c_wr_max - 1)) { + remaining -= FW_BUF_SIZE) { len = remaining; - if (len > (dev->i2c_wr_max - 1)) - len = (dev->i2c_wr_max - 1); + if (len > FW_BUF_SIZE) + len = FW_BUF_SIZE; ret = regmap_bulk_write(dev->regmap[0], 0xf6, &fw->data[fw->size - remaining], len);