From patchwork Sat Nov 15 10:52:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Utkin X-Patchwork-Id: 26970 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1XpazG-0008BA-GA; Sat, 15 Nov 2014 11:53:50 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1XpazD-0007ns-m6; Sat, 15 Nov 2014 11:53:49 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754081AbaKOKxf (ORCPT + 1 other); Sat, 15 Nov 2014 05:53:35 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:39707 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbaKOKxe (ORCPT ); Sat, 15 Nov 2014 05:53:34 -0500 Received: by mail-wi0-f177.google.com with SMTP id l15so4934513wiw.10 for ; Sat, 15 Nov 2014 02:53:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=veGEMZ1kjHW/etAWkOsy0/TnrCdOF0EISdfrBdU3WJU=; b=Vs5qYMh9SQukdXIl+7gNlQyhphHhTpnc3yI4I5ZNQfiIlMpqAh5T29KVAc+uwnI3wi p8l3/nZD8HJuH061tYBmbBGH6bRZ5FkjNQ3cu9jC4Le2lhsaO1EZL/AMf/XwSWvtg8IJ 3/mnkPGxE/3T0ynmCw/FDR+dsygTiK2wLCIi0tvrJlr4+5uL/aSDNut3QWnh1xEYyKlR DtwfbqvC0N0u3+jWrFMHdSI/Upl4CnPHuYXO1sE+JXw0cChuzGX2Cq5Q8u/j2ma2h2f8 a6gfMu7U1st14FZ//jTGYxw61OP/1YI/CyYiiuBH4vliC/oDzfFegKrO3D+xfJKFeWVV w0WQ== X-Gm-Message-State: ALoCoQmEFG00XAq6GqJpH8d4tV8v87TiTG81IaqnILNvrUhbw8ZuLc/C0vnhQSPlPTX+MoCKxD9K X-Received: by 10.194.92.82 with SMTP id ck18mr21714705wjb.103.1416048812568; Sat, 15 Nov 2014 02:53:32 -0800 (PST) Received: from localhost.localdomain ([73.165.39.130]) by mx.google.com with ESMTPSA id fv5sm740636wjc.37.2014.11.15.02.53.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Nov 2014 02:53:31 -0800 (PST) From: Andrey Utkin To: khalasa@piap.pl, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, m.chehab@samsung.com, hverkuil@xs4all.nl Subject: [PATCH] solo6x10: fix a race in IRQ handler Date: Sat, 15 Nov 2014 14:52:26 +0400 Message-Id: <1416048746-12717-1-git-send-email-andrey.utkin@corp.bluecherry.net> X-Mailer: git-send-email 2.0.4 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.11.15.104222 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1500_1599 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __DATE_TZ_RU 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_TO_X5 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Krzysztof Ha?asa The IRQs have to be acknowledged before they are serviced, otherwise some events may be skipped. Also, acknowledging IRQs just before returning from the handler doesn't leave enough time for the device to deassert the INTx line, and for bridges to propagate this change. This resulted in twice the IRQ rate on ARMv6 dual core CPU. Signed-off-by: Krzysztof Ha?asa Acked-by: Andrey Utkin Tested-by: Andrey Utkin the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/media/pci/solo6x10/solo6x10-core.c +++ b/drivers/media/pci/solo6x10/solo6x10-core.c @@ -105,11 +105,8 @@ static irqreturn_t solo_isr(int irq, void *data) if (!status) return IRQ_NONE; - if (status & ~solo_dev->irq_mask) { - solo_reg_write(solo_dev, SOLO_IRQ_STAT, - status & ~solo_dev->irq_mask); - status &= solo_dev->irq_mask; - } + /* Acknowledge all interrupts immediately */ + solo_reg_write(solo_dev, SOLO_IRQ_STAT, status); if (status & SOLO_IRQ_PCI_ERR) solo_p2m_error_isr(solo_dev); @@ -132,9 +129,6 @@ static irqreturn_t solo_isr(int irq, void *data) if (status & SOLO_IRQ_G723) solo_g723_isr(solo_dev); - /* Clear all interrupts handled */ - solo_reg_write(solo_dev, SOLO_IRQ_STAT, status); - return IRQ_HANDLED; } -- To unsubscribe from this list: send the line "unsubscribe linux-media" in