From patchwork Mon Aug 4 19:27:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schwarzott X-Patchwork-Id: 25164 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1XENvX-0006D5-P4; Mon, 04 Aug 2014 21:28:11 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1XENvV-0003dP-mH; Mon, 04 Aug 2014 21:28:11 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751558AbaHDT2H (ORCPT + 1 other); Mon, 4 Aug 2014 15:28:07 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:36497 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbaHDT2G (ORCPT ); Mon, 4 Aug 2014 15:28:06 -0400 Received: from gauss.fritz.box (host-188-174-204-36.customer.m-online.net [188.174.204.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zzam) by smtp.gentoo.org (Postfix) with ESMTPSA id 49546340166; Mon, 4 Aug 2014 19:28:03 +0000 (UTC) From: Matthias Schwarzott To: linux-media@vger.kernel.org, crope@iki.fi, m.chehab@samsung.com Cc: fengguang.wu@intel.com, Matthias Schwarzott Subject: [PATCH] si2165: change return type of si2165_wait_init_done from bool to int Date: Mon, 4 Aug 2014 21:27:43 +0200 Message-Id: <1407180463-17936-1-git-send-email-zzam@gentoo.org> X-Mailer: git-send-email 2.0.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.8.4.192119 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' In case of an error -EINVAL will be mis-casted to 1. This was triggered by a coccinelle warning. Signed-off-by: Matthias Schwarzott --- drivers/media/dvb-frontends/si2165.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index 3a2d6c5..f02d946 100644 --- a/drivers/media/dvb-frontends/si2165.c +++ b/drivers/media/dvb-frontends/si2165.c @@ -312,9 +312,8 @@ static u32 si2165_get_fe_clk(struct si2165_state *state) return state->adc_clk; } -static bool si2165_wait_init_done(struct si2165_state *state) +static int si2165_wait_init_done(struct si2165_state *state) { - int ret = -EINVAL; u8 val = 0; int i; @@ -326,7 +325,7 @@ static bool si2165_wait_init_done(struct si2165_state *state) } dev_err(&state->i2c->dev, "%s: init_done was not set\n", KBUILD_MODNAME); - return ret; + return -EINVAL; } static int si2165_upload_firmware_block(struct si2165_state *state,