From patchwork Thu Jul 17 19:38:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Alves X-Patchwork-Id: 24888 X-Patchwork-Delegate: mkrufky@linuxtv.org Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1X7rVT-0003l6-2H; Thu, 17 Jul 2014 21:38:20 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1X7rVQ-0006Xm-8r; Thu, 17 Jul 2014 21:38:18 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753323AbaGQTiO (ORCPT + 1 other); Thu, 17 Jul 2014 15:38:14 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:43383 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752570AbaGQTiO (ORCPT ); Thu, 17 Jul 2014 15:38:14 -0400 Received: by mail-wi0-f179.google.com with SMTP id f8so3393003wiw.12 for ; Thu, 17 Jul 2014 12:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=jUVwufQtgOCJP3XvMtFpcUDIAfuoE3JyPaCooW8ZIe4=; b=uGI7zVcmqF7xGMl2oHHVtgrTpZWB1Tyiq2jyHOcEKLZHFJYKVgnagBJSJCoTp+B48p PWU+H18Z4KubE38fHNkWqBGog6z8OhoCWBiQFb8RaJkukg/6BCjtGZh6ANrljvywEv0g H0YEgbJjNS6NP6sfa51YT5Je3EHhqnevWYYMLjyNAMADiPb+41Eg1SA43SeQK2C2lynf wZ1S96CTS81cIt7ByVby7U10p4jz7bQ34HzmnrtQDIhaThAHGPqpd8fD7UFM8k1wFB/f kMWZpaW3OveTcMXkPF3EWbG7QBzDUeR33yKI2q1qwGpgfG+xG6B83Of8fVyJMgVPyfg1 BmKw== X-Received: by 10.180.75.75 with SMTP id a11mr24862044wiw.3.1405625892891; Thu, 17 Jul 2014 12:38:12 -0700 (PDT) Received: from localhost.localdomain (a89-152-208-230.cpe.netcabo.pt. [89.152.208.230]) by mx.google.com with ESMTPSA id fs17sm8350328wjc.6.2014.07.17.12.38.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Jul 2014 12:38:12 -0700 (PDT) From: Luis Alves To: linux-media@vger.kernel.org Cc: crope@iki.fi, Luis Alves Subject: [PATCH 1/1] si2168: Fix i2c_add_mux_adapter return value in probe function. In case it failed the return value was always 0. Date: Thu, 17 Jul 2014 20:38:08 +0100 Message-Id: <1405625888-9056-1-git-send-email-ljalvs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.7.17.193021 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/si2168.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 7980741..3fed522 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -619,8 +619,10 @@ static int si2168_probe(struct i2c_client *client, /* create mux i2c adapter for tuner */ s->adapter = i2c_add_mux_adapter(client->adapter, &client->dev, s, 0, 0, 0, si2168_select, si2168_deselect); - if (s->adapter == NULL) + if (s->adapter == NULL) { + ret = -ENODEV; goto err; + } /* create dvb_frontend */ memcpy(&s->fe.ops, &si2168_ops, sizeof(struct dvb_frontend_ops));