From patchwork Wed Jun 4 18:46:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 24163 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1WsGDP-0003od-Fj; Wed, 04 Jun 2014 20:47:11 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1WsGDN-0006UY-ky; Wed, 04 Jun 2014 20:47:11 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751508AbaFDSqs (ORCPT + 1 other); Wed, 4 Jun 2014 14:46:48 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:54656 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751722AbaFDSqo (ORCPT ); Wed, 4 Jun 2014 14:46:44 -0400 Received: by mail-yk0-f180.google.com with SMTP id q9so6427035ykb.39 for ; Wed, 04 Jun 2014 11:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IDupjsInNNKyUoPHt8ZoJ0d7ZkcjWd9SP4I7YdzMfR4=; b=QW4l+Qd9nwCp/enx/RTRI80bsN1o6zdQ+TocnD3jNCtegSBTvYln3Jv+6rCkZ3sw/V GkP48Ng4YIZcfMYJShv7HUS/dFMohI99f+k4AvDeTky6vXsgoXEyUmlqMXDyqnT0l6pr mnoTjDumi+Hu3co9V42KNp9nYRyAVDfpOJwwQvUMERoeEyiLQXsnNQvo3H3lSVCiCtiS ccK0cRDp0PtAQ0vWRLgr72fWsnTspS8qAi3/fIyPL03H/Ylv96ULWdBMQA5J/Qgf+Tn0 mHlAsKyzHGkxBNO/rD4NwhL3W56Kcix4dCeFcYM8FnplFoCXzPBsW8kxD4J46I6DlMp5 nD5A== X-Received: by 10.236.18.195 with SMTP id l43mr27092279yhl.150.1401907603925; Wed, 04 Jun 2014 11:46:43 -0700 (PDT) Received: from localhost.localdomain ([177.194.47.191]) by mx.google.com with ESMTPSA id b67sm4968856yhc.16.2014.06.04.11.46.42 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Jun 2014 11:46:43 -0700 (PDT) From: Fabio Estevam To: m.chehab@samsung.com Cc: p.zabel@pengutronix.de, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH v2 2/2] [media] coda: Propagate the correct error on devm_request_threaded_irq() Date: Wed, 4 Jun 2014 15:46:24 -0300 Message-Id: <1401907584-30218-2-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1401907584-30218-1-git-send-email-festevam@gmail.com> References: <1401907584-30218-1-git-send-email-festevam@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.6.4.183921 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1400_1499 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Fabio Estevam If devm_request_threaded_irq() fails, we should better propagate the real error. Also, print out the error code in the dev_err message. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v1: - None. Only rebased against latest tree drivers/media/platform/coda.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index 32b3b6d..661bbe6 100644 --- a/drivers/media/platform/coda.c +++ b/drivers/media/platform/coda.c @@ -3232,10 +3232,11 @@ static int coda_probe(struct platform_device *pdev) return irq; } - if (devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler, - IRQF_ONESHOT, dev_name(&pdev->dev), dev) < 0) { - dev_err(&pdev->dev, "failed to request irq\n"); - return -ENOENT; + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler, + IRQF_ONESHOT, dev_name(&pdev->dev), dev); + if (ret < 0) { + dev_err(&pdev->dev, "failed to request irq: %d\n", ret); + return ret; } /* Get IRAM pool from device tree or platform data */