From patchwork Wed Jun 4 18:46:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 24162 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1WsGDO-0003oO-FM; Wed, 04 Jun 2014 20:47:10 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1WsGDL-0006UY-kr; Wed, 04 Jun 2014 20:47:09 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbaFDSqo (ORCPT + 1 other); Wed, 4 Jun 2014 14:46:44 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:43249 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751722AbaFDSqn (ORCPT ); Wed, 4 Jun 2014 14:46:43 -0400 Received: by mail-yk0-f179.google.com with SMTP id 19so6419750ykq.10 for ; Wed, 04 Jun 2014 11:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=HYalJPEvKE60/c1CryR47BISrpuyDtNdORzIX9/o1G8=; b=XrGmszdvgrWEGa3s0ZybHgnYl0alB83JtRyEuPKw7RhxfRB4vg0m09tX0bL2W5s5lB cNC1UsdByQqU/0qaP7AFMa1desTheT+RU/JNZlRyN518D2aznY/aHY6AHu+l7TfFeI2x v6+ZQQgpo+KUn1rwP+WIvSW6NMV/A6zdU7Hqh3M4crcMDX14GxMLdLYLAVWTScFwhpIl LHOOUsNsTfSMd4di0ZdckoVCnsu2XqhaqC//f/X6KlL7eYoxEvh5+krnk9QTvBLUqlHA vyhPFX1z8Fv/ERJNNAUlIIEDmuOcPDSkJHsH8tl2gK/L9x5FpDrAhEfxndcNrfdc9IYa 3+nw== X-Received: by 10.236.126.174 with SMTP id b34mr75290124yhi.56.1401907602308; Wed, 04 Jun 2014 11:46:42 -0700 (PDT) Received: from localhost.localdomain ([177.194.47.191]) by mx.google.com with ESMTPSA id b67sm4968856yhc.16.2014.06.04.11.46.40 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Jun 2014 11:46:41 -0700 (PDT) From: Fabio Estevam To: m.chehab@samsung.com Cc: p.zabel@pengutronix.de, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH v2 1/2] [media] coda: Return the real error on platform_get_irq() Date: Wed, 4 Jun 2014 15:46:23 -0300 Message-Id: <1401907584-30218-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.3.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.6.4.183921 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Fabio Estevam No need to return a 'fake' return value on platform_get_irq() failure. Propagate the real error instead. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v1: - None. Only rebased against latest tree drivers/media/platform/coda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index b178379..32b3b6d 100644 --- a/drivers/media/platform/coda.c +++ b/drivers/media/platform/coda.c @@ -3229,7 +3229,7 @@ static int coda_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { dev_err(&pdev->dev, "failed to get irq resource\n"); - return -ENOENT; + return irq; } if (devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,