From patchwork Mon Dec 30 13:37:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Frank Schaefer X-Patchwork-Id: 21387 X-Patchwork-Delegate: mkrufky@linuxtv.org Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Vxd1o-0000jg-NE; Mon, 30 Dec 2013 14:37:08 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1Vxd1m-0002el-1c; Mon, 30 Dec 2013 14:37:08 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755634Ab3L3NhE (ORCPT + 1 other); Mon, 30 Dec 2013 08:37:04 -0500 Received: from mail-ea0-f180.google.com ([209.85.215.180]:50217 "EHLO mail-ea0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751820Ab3L3NhD (ORCPT ); Mon, 30 Dec 2013 08:37:03 -0500 Received: by mail-ea0-f180.google.com with SMTP id f15so5108992eak.11 for ; Mon, 30 Dec 2013 05:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=d9i3kqaPQBD9MLFeubB+TolIkE462W9XKeCcm2XLWMs=; b=dH3KD2zoTj8tNtpvdozLVK6P6tZVEU0tqzzJ0BYjAhWVCHwfDXHP8jqOr8K//cCCwo gtXLV0djU5YKdt/QnHEAq6+rFCgTfWsiJMje9zfXzeNdqPrJ496F8ZIZgIXDyzWvz8oW +OpbHz1EcbUbEd56aVDZv3zLcrGCLEo9rovm0W007FsauK1b4ETtZFCowC7i1IIRD8af w0MCZ/b9OxQYMEL0ARCudX9r5Sy1lGt6JhTZegr/Fm57+BnrrCo8h3ZzN3BhN75D3k9s yy9WDBf+lTwI44t6v0UGmY1XD+qHFZ9SQ93hj88YsaDMOaVF35hl8bAKEk0euehVspSu Vm5g== X-Received: by 10.15.45.135 with SMTP id b7mr1670373eew.88.1388410621378; Mon, 30 Dec 2013 05:37:01 -0800 (PST) Received: from Athlon64X2-5000.site (ip-109-90-246-70.unitymediagroup.de. [109.90.246.70]) by mx.google.com with ESMTPSA id o47sm108773101eem.21.2013.12.30.05.37.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Dec 2013 05:37:01 -0800 (PST) From: =?UTF-8?q?Frank=20Sch=C3=A4fer?= To: m.chehab@samsung.com Cc: linux-media@vger.kernel.org, =?UTF-8?q?Frank=20Sch=C3=A4fer?= Subject: [PATCH] xc2028: disable device power-down because power state handling is broken Date: Mon, 30 Dec 2013 14:37:58 +0100 Message-Id: <1388410678-12641-1-git-send-email-fschaefer.oss@googlemail.com> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.12.30.133016 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' xc2028 power state handling is broken. I2C read/write operations fail when the device is powered down at that moment, which causes the get_rf_strength and get_rf_strength callbacks (and probably others, too) to fail. I don't know how to fix this properly, so disable the device power-down until anyone comes up with a better solution. Signed-off-by: Frank Schäfer --- drivers/media/tuners/tuner-xc2028.c | 4 +++- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/tuners/tuner-xc2028.c b/drivers/media/tuners/tuner-xc2028.c index 4be5cf8..cb3dc5e 100644 --- a/drivers/media/tuners/tuner-xc2028.c +++ b/drivers/media/tuners/tuner-xc2028.c @@ -1291,16 +1291,18 @@ static int xc2028_sleep(struct dvb_frontend *fe) dump_stack(); } + /* FIXME: device power-up/-down handling is broken */ +/* mutex_lock(&priv->lock); if (priv->firm_version < 0x0202) rc = send_seq(priv, {0x00, XREG_POWER_DOWN, 0x00, 0x00}); else rc = send_seq(priv, {0x80, XREG_POWER_DOWN, 0x00, 0x00}); - priv->state = XC2028_SLEEP; mutex_unlock(&priv->lock); +*/ return rc; }