From patchwork Fri Nov 29 07:50:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seung-Woo Kim X-Patchwork-Id: 20840 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VmIqU-0001Qo-2w; Fri, 29 Nov 2013 08:50:38 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1VmIqR-0000ww-5Y; Fri, 29 Nov 2013 08:50:37 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751177Ab3K2Hud (ORCPT + 1 other); Fri, 29 Nov 2013 02:50:33 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:22558 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089Ab3K2Huc (ORCPT ); Fri, 29 Nov 2013 02:50:32 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MX000IBRLS2YS10@mailout1.samsung.com> for linux-media@vger.kernel.org; Fri, 29 Nov 2013 16:50:26 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.115]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id AB.EB.18301.14748925; Fri, 29 Nov 2013 16:50:25 +0900 (KST) X-AuditID: cbfee68e-b7f7e6d00000477d-e9-52984741bed6 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 0C.6A.32308.14748925; Fri, 29 Nov 2013 16:50:25 +0900 (KST) Received: from localhost.localdomain ([10.252.75.83]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MX0008WXLRZBIN0@mmp1.samsung.com>; Fri, 29 Nov 2013 16:50:25 +0900 (KST) From: Seung-Woo Kim To: linux-media@vger.kernel.org, m.szyprowski@samsung.com, m.chehab@samsung.com Cc: pawel@osciak.com, sw0312.kim@samsung.com Subject: [PATCH] [media] videobuf2: Add log for size checking error in __qbuf_dmabuf Date: Fri, 29 Nov 2013 16:50:29 +0900 Message-id: <1385711429-5442-1-git-send-email-sw0312.kim@samsung.com> X-Mailer: git-send-email 1.7.4.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsWyRsSkWNfRfUaQwcXpMhY9G7ayWlxcJ2+x 9shddospb3+yW8yY/JLNgdXj8a+XbB59W1YxenzeJBfAHMVlk5Kak1mWWqRvl8CVce31IaaC V2wVO1b0MTYwXmDtYuTkkBAwkZj6eSsbhC0mceHeeiCbi0NIYCmjxK1/s+GKljXNBysSEljE KPF5cxBEUSuTxIZLi5hAEmwCOhL7l/wGaxAR8Jdo2dzIAmIzA8XfbNgCZgsLhEm0Lb0MVsMi oCrx68l3ZhCbV8BVYtOnr0wQyxQkFtx7C3aFhMB9None51uYIBoEJL5NPgQ0iAMoISux6QAz RL2kxMEVN1gmMAouYGRYxSiaWpBcUJyUXmSkV5yYW1yal66XnJ+7iREYjKf/PevbwXjzgPUh xmSgcROZpUST84HBnFcSb2hsZmRhamJqbGRuaUaasJI476KHSUFCAumJJanZqakFqUXxRaU5 qcWHGJk4OKUaGBOUbk6edbj+nMlzDsGTE02v3zTTy8/Z/EDrSrxY+rvfcZvdddf+MZNs9HBb sbJoVvk9jnCP3ylfbOvV/x+vWCPDrc8hf4svyZJ585WHSwrnJNxxijl9M6afYX1vgEqKyssX z72aby3PSq+5bc0S8Vymu6N9WwDLa9MJuTUtsa+6tY15NBS+K7EUZyQaajEXFScCAJ99GVpc AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t9jAV1H9xlBBsu/ilj0bNjKanFxnbzF 2iN32S2mvP3JbjFj8ks2B1aPx79esnn0bVnF6PF5k1wAc1QDo01GamJKapFCal5yfkpmXrqt kndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0EolhbLEnFKgUEBicbGSvh2mCaEhbroW MI0Rur4hQXA9RgZoIGENY8a114eYCl6xVexY0cfYwHiBtYuRk0NCwERiWdN8NghbTOLCvfVg tpDAIkaJz5uDuhi5gOxWJokNlxYxgSTYBHQk9i/5DdYsIuAv0bK5kQXEZgaKv9mwBcwWFgiT aFt6GayGRUBV4teT78wgNq+Aq8SmT1+ZIJYpSCy495ZtAiP3AkaGVYyiqQXJBcVJ6bmGesWJ ucWleel6yfm5mxjBof5MagfjygaLQ4wCHIxKPLwruqcHCbEmlhVX5h5ilOBgVhLh/VUEFOJN SaysSi3Kjy8qzUktPsSYDLR9IrOUaHI+MA7zSuINjU3MjCyNzA0tjIzNSRNWEuc90GodKCSQ nliSmp2aWpBaBLOFiYNTqoHR8kvbp3ze5G0BSn8ObPNnf7GxSnqShfyWSDuOuf13QheyRti9 MnzluX+PvMfl7+bOa7frJWjyKIXdjfy24cmZZUENMj9b738LtPDdYnBprtOnXXxisvps8/d1 upV5Pypir1Owm/+ir3rSoi2rL1b198lLhuornitN/rHrfZh/asj06GrVLYVKLMUZiYZazEXF iQB8DfzeuQIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.11.29.74215 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SXL_SIG_ERROR_SERVFAIL , __SXL_URI_ERROR_SERVFAIL , __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' __qbuf_dmabuf checks whether size of provided dmabuf is large enough, and it returns error without any log. So this patch adds error log in the case. Signed-off-by: Seung-Woo Kim --- drivers/media/v4l2-core/videobuf2-core.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index b19b306..5faf10c 100644 --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -1116,6 +1116,8 @@ static int __qbuf_dmabuf(struct vb2_buffer *vb, const struct v4l2_buffer *b) if (planes[plane].length < planes[plane].data_offset + q->plane_sizes[plane]) { + dprintk(1, "qbuf: invalid dmabuf length for plane %d\n", + plane); ret = -EINVAL; goto err; }