From patchwork Fri Sep 20 08:36:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 20149 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VMwCc-00086R-9A; Fri, 20 Sep 2013 10:36:38 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1VMwCZ-0007iN-3c; Fri, 20 Sep 2013 10:36:38 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754350Ab3ITIg3 (ORCPT + 1 other); Fri, 20 Sep 2013 04:36:29 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:42422 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754334Ab3ITIg2 (ORCPT ); Fri, 20 Sep 2013 04:36:28 -0400 Received: by mail-pa0-f52.google.com with SMTP id kq13so447526pab.39 for ; Fri, 20 Sep 2013 01:36:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nJYesoJs9PABFmtggnc7QESeiu/6m9npsZS1yI+DUOk=; b=hOOAZPZ1q5iwPPY/eHVbtrQkY0omm29ncCeNKXVH8aoelA9GzZhpFPG/tFHD7O3lvl 20HWGg73FzBML4+ra274v8DQc+Y0LzTtD0+Svw8WVFVlrcI0flS3dd2EUghXKabYQDO9 8uWDfWZSMnln/bT1kdvNV0GVuaed3NMEJHj2LWjh5FgpDSEDvml/weJLHNZlWJVoHgEL PLjNVA9msHuHY7zVp6zSuWJzfk+vsxcD7Y8w/Mb3lsNPyNbAhb3Y/o8XDX0/yjzv3OZY a/RtXS2tQKlPif430llEQxQWVw1DqM/ty3xO5EtZL0WhvpBPEIc9mv33DF23tIkT6rWi /XAg== X-Gm-Message-State: ALoCoQlO+huroQ1008g0WMETSY1LiCvOBuPiiglLIMQ5/fX4cdmgfNhgiSmPjIRfXtt2yeQQIB/d X-Received: by 10.68.134.133 with SMTP id pk5mr6591203pbb.89.1379666187682; Fri, 20 Sep 2013 01:36:27 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id mr3sm14271180pbb.27.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Sep 2013 01:36:27 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: m.chehab@samsung.com, sachin.kamat@linaro.org Subject: [PATCH 9/9] [media] pci: ngene: Remove redundant pci_set_drvdata Date: Fri, 20 Sep 2013 14:06:21 +0530 Message-Id: <1379666181-19546-9-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1379666181-19546-1-git-send-email-sachin.kamat@linaro.org> References: <1379666181-19546-1-git-send-email-sachin.kamat@linaro.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.20.82715 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat --- drivers/media/pci/ngene/ngene-core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/ngene/ngene-core.c b/drivers/media/pci/ngene/ngene-core.c index 37ebc42..8402ed6 100644 --- a/drivers/media/pci/ngene/ngene-core.c +++ b/drivers/media/pci/ngene/ngene-core.c @@ -1648,7 +1648,6 @@ void ngene_remove(struct pci_dev *pdev) cxd_detach(dev); ngene_stop(dev); ngene_release_buffers(dev); - pci_set_drvdata(pdev, NULL); pci_disable_device(pdev); } @@ -1702,6 +1701,5 @@ fail1: ngene_release_buffers(dev); fail0: pci_disable_device(pci_dev); - pci_set_drvdata(pci_dev, NULL); return stat; }