From patchwork Fri Sep 20 08:36:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 20143 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VMwCJ-00082v-UV; Fri, 20 Sep 2013 10:36:19 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1VMwCH-0002ME-2u; Fri, 20 Sep 2013 10:36:19 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754327Ab3ITIgQ (ORCPT + 1 other); Fri, 20 Sep 2013 04:36:16 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:58470 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754317Ab3ITIgP (ORCPT ); Fri, 20 Sep 2013 04:36:15 -0400 Received: by mail-pd0-f173.google.com with SMTP id p10so125641pdj.18 for ; Fri, 20 Sep 2013 01:36:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hfGYHcXJX/6bMu9O41S6bWMeahElfjjCUxaiR2iE/Qs=; b=bQ6fyMIqDpnZFvU7Z20RmPb9ujb4VCRiOrhntt4xC2uSBzfpxS8GrHWyIoUhbc4aEB kjWyNSoqw01KD/3ldxBQJXidbIqQnHqIsbnn0UbQyd3wnxy0smBEYgNyNyTG3BkMAKjz +ifrR0qTV+qc6FbtaRbj6lFXI5/Cs/TOdSBrNs8HwKVlMOoT6jvyGoMTkF8kDnpcbvXA o0GD8EjIFNV8kmLbAEOSe3/qJg8DZ7Z+XDN03Uuv0AGsvru5q3oUDPX4ie+ZZ8UTQhEe yDlcWOEoUBcX6NT62T4/mFnFnq0n1Khl9UqIO2r7LWcnlpD5WoTFnRcARmXdvNMK3Jrw aDVw== X-Gm-Message-State: ALoCoQlV/A/YCMxSwbz+q7oMao+B0gmQRx2ZbRbLjUYNBwi4Ba/6yo2ydGV95TiwkidSQKaP/MYX X-Received: by 10.66.180.200 with SMTP id dq8mr7623177pac.104.1379666175172; Fri, 20 Sep 2013 01:36:15 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id mr3sm14271180pbb.27.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Sep 2013 01:36:14 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: m.chehab@samsung.com, sachin.kamat@linaro.org, "Igor M. Liplianin" Subject: [PATCH 3/9] [media] pci: dm1105: Remove redundant pci_set_drvdata Date: Fri, 20 Sep 2013 14:06:15 +0530 Message-Id: <1379666181-19546-3-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1379666181-19546-1-git-send-email-sachin.kamat@linaro.org> References: <1379666181-19546-1-git-send-email-sachin.kamat@linaro.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.20.82715 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat Cc: Igor M. Liplianin --- drivers/media/pci/dm1105/dm1105.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c index ab797fe..e985e3b 100644 --- a/drivers/media/pci/dm1105/dm1105.c +++ b/drivers/media/pci/dm1105/dm1105.c @@ -1178,7 +1178,6 @@ err_pci_release_regions: err_pci_disable_device: pci_disable_device(pdev); err_kfree: - pci_set_drvdata(pdev, NULL); kfree(dev); return ret; } @@ -1211,7 +1210,6 @@ static void dm1105_remove(struct pci_dev *pdev) pci_iounmap(pdev, dev->io_mem); pci_release_regions(pdev); pci_disable_device(pdev); - pci_set_drvdata(pdev, NULL); dm1105_devcount--; kfree(dev); }