From patchwork Fri Sep 20 08:36:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 20141 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VMwCF-00082Y-Qj; Fri, 20 Sep 2013 10:36:15 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1VMwCD-0002ME-36; Fri, 20 Sep 2013 10:36:15 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253Ab3ITIgM (ORCPT + 1 other); Fri, 20 Sep 2013 04:36:12 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:59639 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754174Ab3ITIgL (ORCPT ); Fri, 20 Sep 2013 04:36:11 -0400 Received: by mail-pa0-f47.google.com with SMTP id kl13so451181pab.6 for ; Fri, 20 Sep 2013 01:36:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nbbVZi6GjiiqSP5u00akdV21mVrrlYbTOJOPnRD8oPQ=; b=WiHF08ulHsjE0tfaoTLODwGbaSWiIQHeIhAqqcZQcDJVCEco+JmiudsOITwcxanmqu pxT+G7iKnkDxpB9UN0Ja8dVpA/tMcFNAUUktYXHr/UndQhgx1b9ATyYXVwO0BvIOwGe2 EBiswDtmUxQ3UbZWUgchOtVFwQ/PjmjVzpRAi1+iYG83A0xEO1uM1PDaFsicyluXf7BX IRbzpKsKw7AeR9BdvGzLBkKPzmAYP99yOU/e+fAKbkZPMEcnSOz2GlGOz1Ma0hs2Iw6r vgBceInoyUtPo2Po72+qHtTdRuwgsZPhboTcXmxQSBoN8maqYWfChY/5KavHwjnN0hNu CZwg== X-Gm-Message-State: ALoCoQlnIrq3RGDfQubmtG+MwfpixmEFKwRnrIBSHLiYN1kYErF+boB1H8eJS07WGCcVQQpj9zQe X-Received: by 10.68.243.99 with SMTP id wx3mr1905734pbc.179.1379666170680; Fri, 20 Sep 2013 01:36:10 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id mr3sm14271180pbb.27.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Sep 2013 01:36:10 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: m.chehab@samsung.com, sachin.kamat@linaro.org, Patrick Boettcher Subject: [PATCH 1/9] [media] pci: flexcop: Remove redundant pci_set_drvdata Date: Fri, 20 Sep 2013 14:06:13 +0530 Message-Id: <1379666181-19546-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.20.82715 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat Cc: Patrick Boettcher Acked-by: Hans Verkuil --- drivers/media/pci/b2c2/flexcop-pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/b2c2/flexcop-pci.c b/drivers/media/pci/b2c2/flexcop-pci.c index 447afbd..8b5e0b3 100644 --- a/drivers/media/pci/b2c2/flexcop-pci.c +++ b/drivers/media/pci/b2c2/flexcop-pci.c @@ -319,7 +319,6 @@ static int flexcop_pci_init(struct flexcop_pci *fc_pci) err_pci_iounmap: pci_iounmap(fc_pci->pdev, fc_pci->io_mem); - pci_set_drvdata(fc_pci->pdev, NULL); err_pci_release_regions: pci_release_regions(fc_pci->pdev); err_pci_disable_device: @@ -332,7 +331,6 @@ static void flexcop_pci_exit(struct flexcop_pci *fc_pci) if (fc_pci->init_state & FC_PCI_INIT) { free_irq(fc_pci->pdev->irq, fc_pci); pci_iounmap(fc_pci->pdev, fc_pci->io_mem); - pci_set_drvdata(fc_pci->pdev, NULL); pci_release_regions(fc_pci->pdev); pci_disable_device(fc_pci->pdev); }