From patchwork Tue Aug 20 19:29:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 19822 X-Patchwork-Delegate: kamil@wypas.org Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VBrfy-0004fR-MS; Tue, 20 Aug 2013 21:33:10 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1VBrfw-00075s-4i; Tue, 20 Aug 2013 21:33:10 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775Ab3HTTdE (ORCPT + 1 other); Tue, 20 Aug 2013 15:33:04 -0400 Received: from [213.199.154.249] ([213.199.154.249]:4699 "EHLO db9outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751763Ab3HTTdC (ORCPT ); Tue, 20 Aug 2013 15:33:02 -0400 Received: from mail88-db9-R.bigfish.com (10.174.16.240) by DB9EHSOBE029.bigfish.com (10.174.14.92) with Microsoft SMTP Server id 14.1.225.22; Tue, 20 Aug 2013 19:31:51 +0000 Received: from mail88-db9 (localhost [127.0.0.1]) by mail88-db9-R.bigfish.com (Postfix) with ESMTP id 171D63E0060; Tue, 20 Aug 2013 19:31:51 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: 0 X-BigFish: VS0(zzzz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1de098h8275bh1de097hz2dh2a8h839hd24he5bhf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e23h1fe8h1ff5h1155h) Received: from mail88-db9 (localhost.localdomain [127.0.0.1]) by mail88-db9 (MessageSwitch) id 137702710951392_13049; Tue, 20 Aug 2013 19:31:49 +0000 (UTC) Received: from DB9EHSMHS007.bigfish.com (unknown [10.174.16.243]) by mail88-db9.bigfish.com (Postfix) with ESMTP id 07ACF300049; Tue, 20 Aug 2013 19:31:49 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by DB9EHSMHS007.bigfish.com (10.174.14.17) with Microsoft SMTP Server (TLS) id 14.16.227.3; Tue, 20 Aug 2013 19:31:48 +0000 Received: from tx30smr01.am.freescale.net (10.81.153.31) by 039-SN1MMR1-003.039d.mgd.msft.net (10.84.1.16) with Microsoft SMTP Server (TLS) id 14.3.146.2; Tue, 20 Aug 2013 19:31:47 +0000 Received: from fabio-OptiPlex-7010.am.freescale.net ([10.29.244.68]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id r7KJVg0G006884; Tue, 20 Aug 2013 12:31:46 -0700 From: Fabio Estevam To: CC: , , Fabio Estevam Subject: [PATCH v6 3/3] [media] coda: No need to check the return value of platform_get_resource() Date: Tue, 20 Aug 2013 16:29:38 -0300 Message-ID: <1377026978-23322-3-git-send-email-fabio.estevam@freescale.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1377026978-23322-1-git-send-email-fabio.estevam@freescale.com> References: <1377026978-23322-1-git-send-email-fabio.estevam@freescale.com> MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.8.20.192128 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v5: - Rebased against latest Kamil's tree drivers/media/platform/coda.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index a68379c..7ac8f46 100644 --- a/drivers/media/platform/coda.c +++ b/drivers/media/platform/coda.c @@ -3154,11 +3154,6 @@ static int coda_probe(struct platform_device *pdev) /* Get memory for physical registers */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (res == NULL) { - dev_err(&pdev->dev, "failed to get memory region resource\n"); - return -ENOENT; - } - dev->regs_base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(dev->regs_base)) return PTR_ERR(dev->regs_base);