From patchwork Tue Aug 20 08:48:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seung-Woo Kim X-Patchwork-Id: 19810 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VBhcV-0003VY-Gk; Tue, 20 Aug 2013 10:48:55 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1VBhcT-0001zw-4q; Tue, 20 Aug 2013 10:48:55 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533Ab3HTIsu (ORCPT + 1 other); Tue, 20 Aug 2013 04:48:50 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:25516 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322Ab3HTIsA (ORCPT ); Tue, 20 Aug 2013 04:48:00 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MRT00ETVN3V8N50@mailout2.samsung.com> for linux-media@vger.kernel.org; Tue, 20 Aug 2013 17:47:55 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.114]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 70.21.29708.B3D23125; Tue, 20 Aug 2013 17:47:55 +0900 (KST) X-AuditID: cbfee690-b7f6f6d00000740c-63-52132d3b212d Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F8.DB.31505.B3D23125; Tue, 20 Aug 2013 17:47:55 +0900 (KST) Received: from localhost.localdomain ([10.252.75.83]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MRT009LEN3TV530@mmp2.samsung.com>; Tue, 20 Aug 2013 17:47:55 +0900 (KST) From: Seung-Woo Kim To: linux-media@vger.kernel.org, m.szyprowski@samsung.com, m.chehab@samsung.com Cc: pawel@osciak.com, sw0312.kim@samsung.com, heejin.woo@samsung.com Subject: [PATCH] media: vb2: add log for size checking error in __qbuf_userptr Date: Tue, 20 Aug 2013 17:48:06 +0900 Message-id: <1376988486-17512-1-git-send-email-sw0312.kim@samsung.com> X-Mailer: git-send-email 1.7.4.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsWyRsSkSNdaVzjI4NcyCYu9y/pZLXo2bGW1 uLhO3mLtkbvsFlPe/mS3mDH5JZsDm8fjXy/ZPPq2rGL0+LxJLoA5issmJTUnsyy1SN8ugSvj 0LH9LAXP2Cva139kamDcwtbFyMkhIWAi8ebTViYIW0ziwr31QHEuDiGBpYwS75atZocpmvLw DTtEYjqjxNMNT5kgnFYmia4lX8BGsQnoSOxf8psVxBYR8Jdo2dzI0sXIwcEs4CLxfokXSFhY wE+if8d8RhCbRUBV4tKCVSwgNq+Am8TUl3uZIZYpSCy49xbsCgmB92wSlz+uY4NoEJD4NvkQ 2EwJAVmJTQeg6iUlDq64wTKBUXABI8MqRtHUguSC4qT0IhO94sTc4tK8dL3k/NxNjMCwPP3v 2YQdjPcOWB9iTAYaN5FZSjQ5HxjWeSXxhsZmRhamJqbGRuaWZqQJK4nzqrdYBwoJpCeWpGan phakFsUXleakFh9iZOLglGpgXDhlU3r++f0aejzBj1Pd1yV8P7/5QE7C4W2aoht8D/qlBUVO 3FnTKuj4xm/Sd7UtD36Gf5rL8u6iLss13wX3CsN/FS858ljUkod70RmL+U/+KE65EWrAG7iU ta/sb4TFZJuFv5ctfG2hqcE5scuEq5il9srS153WP6q6NjmsPFsd3312X/glCyWW4oxEQy3m ouJEACPl6ddhAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsVy+t9jQV1rXeEgg8vLBC32LutntejZsJXV 4uI6eYu1R+6yW0x5+5PdYsbkl2wObB6Pf71k8+jbsorR4/MmuQDmqAZGm4zUxJTUIoXUvOT8 lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygvUoKZYk5pUChgMTiYiV9O0wT QkPcdC1gGiN0fUOC4HqMDNBAwhrGjEPH9rMUPGOvaF//kamBcQtbFyMnh4SAicSUh2/YIWwx iQv31gPFuTiEBKYzSjzd8JQJwmllkuha8gWsg01AR2L/kt+sILaIgL9Ey+ZGli5GDg5mAReJ 90u8QMLCAn4S/TvmM4LYLAKqEpcWrGIBsXkF3CSmvtzLDLFMQWLBvbdsExi5FzAyrGIUTS1I LihOSs810itOzC0uzUvXS87P3cQIDvpn0jsYVzVYHGIU4GBU4uHtUBIKEmJNLCuuzD3EKMHB rCTC+0JZOEiINyWxsiq1KD++qDQntfgQYzLQ9onMUqLJ+cCIzCuJNzQ2MTOyNDI3tDAyNidN WEmc92CrdaCQQHpiSWp2ampBahHMFiYOTqkGRmP7w2pmjKICMdd91CXL9q1S2/lhP9uhmQ95 Zq5+IDAnOXXG/6l7X66oPuD1a/3UCP6fau7OdxwTtmacuuXWJ566wODqKy6BG15bfl78ILHr tXD8jPkbjk25uTZ1SQ/7HeWzL31jlt9qNN3z7GbvHacCx5ibefH311l4ZAnEWtfdVlZjeeX4 IE2JpTgj0VCLuag4EQC39Vb+vgIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.8.20.83628 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' __qbuf_userptr checks whether provided buffer is large enough, and it returns error without any log. Signed-off-by: Seung-Woo Kim Signed-off-by: Heejin Woo --- drivers/media/v4l2-core/videobuf2-core.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 9fc4bab..96827e8 100644 --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -978,6 +978,10 @@ static int __qbuf_userptr(struct vb2_buffer *vb, const struct v4l2_buffer *b) /* Check if the provided plane buffer is large enough */ if (planes[plane].length < q->plane_sizes[plane]) { + dprintk(1, "qbuf: provided buffer size %u is less than " + "setup size %u for plane %d\n", + planes[plane].length, + q->plane_sizes[plane], plane); ret = -EINVAL; goto err; }