From patchwork Fri Aug 2 08:58:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 19500 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1V5BSO-0001hD-3f; Fri, 02 Aug 2013 11:15:32 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1V5BSM-0002l5-0M; Fri, 02 Aug 2013 11:15:31 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758105Ab3HBJP2 (ORCPT + 1 other); Fri, 2 Aug 2013 05:15:28 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:57495 "EHLO mail-pb0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755010Ab3HBJP1 (ORCPT ); Fri, 2 Aug 2013 05:15:27 -0400 Received: by mail-pb0-f47.google.com with SMTP id rr4so468414pbb.6 for ; Fri, 02 Aug 2013 02:15:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=9IHsTx1H8W9BWWJlL1DnRBXGQk4/htcscUcvRcUPPvg=; b=Qb9Wq1JSmU+2sCOa5KVLjWpxbiJI3DM/iQzceDcow5m9hXc1GmVJFqIM/LjpvJM4zy DEgP8hx86XEgySF4ngSQp7oalqzkSrYGWwlpltVBGkdAI8eLRudckFj8CdlGVyjsrmEK AuAMJjLRydFsXa1jgrouLHMoSdOpTZcuHnt2I6XtGLlZ4pDln8oenk0IbJsQZ+05WI5W HsZOsiU7ceU5P3h/MDw5UA2opDMcxrVJ3F9yAjf5yRiGbd6p2J3JnjKT39IKk+vV+VMy zvjgDXURQsPB4QE9lKqQr1JtbPcUXwb+PIgyGW86kE9uCOm6+ofyJeEdOOJr7bYa83pS zvSQ== X-Received: by 10.68.170.133 with SMTP id am5mr2479481pbc.104.1375434926837; Fri, 02 Aug 2013 02:15:26 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id qh10sm9111563pbb.33.2013.08.02.02.15.24 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 02 Aug 2013 02:15:26 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH v2 3/3] [media] exynos4-is: Fix potential NULL pointer dereference Date: Fri, 2 Aug 2013 14:28:25 +0530 Message-Id: <1375433905-30369-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQk1wpv5klRI6GJVoFFUTHgkcLV6TdfYwCRVpBoeaFoso0gxfMoNZQoQqNWeoaMoCueTrpMr Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.8.2.90618 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1500_1599 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' dev->of_node could be NULL. Hence check for the same and return before dereferencing it in the subsequent error message. Signed-off-by: Sachin Kamat --- Changes since v1: Moved the NULL check to beginning of probe. --- drivers/media/platform/exynos4-is/fimc-lite.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c index 08fbfed..318d4c3 100644 --- a/drivers/media/platform/exynos4-is/fimc-lite.c +++ b/drivers/media/platform/exynos4-is/fimc-lite.c @@ -1504,16 +1504,17 @@ static int fimc_lite_probe(struct platform_device *pdev) struct resource *res; int ret; + if (!dev->of_node) + return -ENODEV; + fimc = devm_kzalloc(dev, sizeof(*fimc), GFP_KERNEL); if (!fimc) return -ENOMEM; - if (dev->of_node) { - of_id = of_match_node(flite_of_match, dev->of_node); - if (of_id) - drv_data = (struct flite_drvdata *)of_id->data; - fimc->index = of_alias_get_id(dev->of_node, "fimc-lite"); - } + of_id = of_match_node(flite_of_match, dev->of_node); + if (of_id) + drv_data = (struct flite_drvdata *)of_id->data; + fimc->index = of_alias_get_id(dev->of_node, "fimc-lite"); if (!drv_data || fimc->index >= drv_data->num_instances || fimc->index < 0) {