From patchwork Fri Jul 26 09:32:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Katsuya MATSUBARA X-Patchwork-Id: 19407 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1V2eOT-0003AY-Hi; Fri, 26 Jul 2013 11:33:01 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1V2eOR-0007hC-1J; Fri, 26 Jul 2013 11:33:01 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758272Ab3GZJc5 (ORCPT + 1 other); Fri, 26 Jul 2013 05:32:57 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:62742 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758403Ab3GZJc4 (ORCPT ); Fri, 26 Jul 2013 05:32:56 -0400 Received: by mail-pa0-f50.google.com with SMTP id fb10so2552350pad.37 for ; Fri, 26 Jul 2013 02:32:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=NhHRA/Q+plHH+Wpb8GNcU93IQ6pfDq9lW89SwvJj6Ww=; b=AFgBsadHbu1oVYEbqRl3XwIq/fh6RLMHZkzRAtFimMSlw9klB6CTBiwUHzI17YZ0Ud GBcaRVZb0NLL8ZHyVlWKXuJpREM5PBMwG/QGaFRpGIqbGLogCbHh9kKfJpiNhqbiO3zQ gTqLF3Gjg0rG0kwmuUMzw0fh6jQ9UkIy9Zuy/cb9oAdgUBbBtbVsnBVR7vV/XuO4utPn dlRZDoe85KG1QbwEuG9sH/Wt4miw+4UBv6GAK+fWaUex1RxJ2Abgvss1n7m93r12VqCD A/i3hrekRZEcW4Jz2cxydpLL+XPChiZD/FEmeZvGF71Ze/cdfPXAUAKMwyylqbHQabu/ OvEw== X-Received: by 10.66.119.196 with SMTP id kw4mr54317606pab.164.1374831175434; Fri, 26 Jul 2013 02:32:55 -0700 (PDT) Received: from kiefer.hq.igel.co.jp ([219.106.231.132]) by mx.google.com with ESMTPSA id ot4sm2578248pac.17.2013.07.26.02.32.53 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Jul 2013 02:32:54 -0700 (PDT) From: Katsuya Matsubara To: Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-sh@vger.kernel.org, Hans Verkuil , Sakari Ailus , Sylwester Nawrocki , Katsuya Matsubara Subject: [PATCH 1/7] [media] vsp1: Fix lack of the sink entity registration for enabled links Date: Fri, 26 Jul 2013 18:32:11 +0900 Message-Id: <1374831137-9219-2-git-send-email-matsu@igel.co.jp> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1374831137-9219-1-git-send-email-matsu@igel.co.jp> References: <1374831137-9219-1-git-send-email-matsu@igel.co.jp> X-Gm-Message-State: ALoCoQlP1j8eeioZVvzoBQGaz7Ca9oala6VDbKWXtlon0r685UmEKwZ1+P1H4R5Tp2/HH2Ec2exd Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.7.26.92426 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Each source entity maintains a pointer to the counterpart sink entity while an enabled link connects them. It should be managed by the setup_link callback in the media controller framework at runtime. However, enabled links which connect RPFs and WPFs that have an equivalent index number are created during initialization. This registers the pointer to a sink entity from the source entity when an enabled link is created. Signed-off-by: Katsuya Matsubara --- drivers/media/platform/vsp1/vsp1_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c index 756929e..0ead308 100644 --- a/drivers/media/platform/vsp1/vsp1_drv.c +++ b/drivers/media/platform/vsp1/vsp1_drv.c @@ -101,6 +101,9 @@ static int vsp1_create_links(struct vsp1_device *vsp1, struct vsp1_entity *sink) entity, pad, flags); if (ret < 0) return ret; + + if (flags & MEDIA_LNK_FL_ENABLED) + source->sink = entity; } }