From patchwork Thu Jul 25 13:09:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregor Jasny X-Patchwork-Id: 19397 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1V2LJf-0006vZ-53; Thu, 25 Jul 2013 15:10:47 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1V2LJc-0006Xq-7k; Thu, 25 Jul 2013 15:10:47 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755869Ab3GYNKl (ORCPT + 1 other); Thu, 25 Jul 2013 09:10:41 -0400 Received: from mail-bk0-f47.google.com ([209.85.214.47]:48547 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755678Ab3GYNKj (ORCPT ); Thu, 25 Jul 2013 09:10:39 -0400 Received: by mail-bk0-f47.google.com with SMTP id jg1so668240bkc.6 for ; Thu, 25 Jul 2013 06:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=Sstwz6lQFETbU85Np2rx00U5RvDQDOHM3eC2xrQ11LQ=; b=hTd/Cp9vtjRccli4vQx5sovunrTtxKI7gGyrxL2XrrsNbSZvcyUeZGPtXZuOAfBJ2p hyAcRsO3HdganWBMi+/GCorj2fCvztTcXzymE64x6pl0ABs4i4rtxCJ6U7zgbgJu60KP bpMiPSykUCjIGjzEL4rXtHxeNJ/CIqOYYEqRo37tcH4N81+ta/ieV9DS8d0DMtQhGysl A7+YLuPkH2Y3wL86eE+ndorRZLCxXF+DjPVfblbPd/Wt5EjI6qr9nCqUcXtrJJoAFu53 gHUg/GOu8Q7rgo/8Bw+NqwSE7CMl3ItakLpED6CXVPulOVuGCxDNHr8h0zrSQN2+SNFZ xYNA== X-Received: by 10.205.130.67 with SMTP id hl3mr5956446bkc.61.1374757837384; Thu, 25 Jul 2013 06:10:37 -0700 (PDT) Received: from gjasny06.drs.expertcity.com ([78.108.113.8]) by mx.google.com with ESMTPSA id eu16sm10949773bkc.0.2013.07.25.06.10.36 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Jul 2013 06:10:36 -0700 (PDT) From: Gregor Jasny To: linux-media@vger.kernel.org Cc: Gregor Jasny , Hans Verkuil Subject: [PATCH 3/4] rds-ctl: Always terminate strings properly Date: Thu, 25 Jul 2013 15:09:33 +0200 Message-Id: <1374757774-29051-4-git-send-email-gjasny@googlemail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1374757774-29051-1-git-send-email-gjasny@googlemail.com> References: <1374757774-29051-1-git-send-email-gjasny@googlemail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.7.25.130016 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Detected by Coverity. Signed-off-by: Gregor Jasny CC: Hans Verkuil --- utils/rds-ctl/rds-ctl.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/utils/rds-ctl/rds-ctl.cpp b/utils/rds-ctl/rds-ctl.cpp index a9fe2a8..74972eb 100644 --- a/utils/rds-ctl/rds-ctl.cpp +++ b/utils/rds-ctl/rds-ctl.cpp @@ -762,13 +762,11 @@ static int parse_cl(int argc, char **argv) params.options[(int)opt] = 1; switch (opt) { case OptSetDevice: - strncpy(params.fd_name, optarg, 80); + strncpy(params.fd_name, optarg, sizeof(params.fd_name)); if (optarg[0] >= '0' && optarg[0] <= '9' && strlen(optarg) <= 3) { - static char newdev[20]; - - sprintf(newdev, "/dev/radio%s", optarg); - strncpy(params.fd_name, newdev, 20); + snprintf(params.fd_name, sizeof(params.fd_name), "/dev/radio%s", optarg); } + params.fd_name[sizeof(params.fd_name) - 1] = '\0'; break; case OptSetFreq: params.freq = strtod(optarg, NULL); @@ -786,7 +784,8 @@ static int parse_cl(int argc, char **argv) { if (access(optarg, F_OK) != -1) { params.filemode_active = true; - strncpy(params.fd_name, optarg, 80); + strncpy(params.fd_name, optarg, sizeof(params.fd_name)); + params.fd_name[sizeof(params.fd_name) - 1] = '\0'; } else { fprintf(stderr, "Unable to open file: %s\n", optarg); return -1; @@ -1006,7 +1005,8 @@ int main(int argc, char **argv) fprintf(stderr, "No RDS-capable device found\n"); exit(1); } - strncpy(params.fd_name, devices[0].c_str(), 80); + strncpy(params.fd_name, devices[0].c_str(), sizeof(params.fd_name)); + params.fd_name[sizeof(params.fd_name) - 1] = '\0'; printf("Using device: %s\n", params.fd_name); } if ((fd = test_open(params.fd_name, O_RDONLY | O_NONBLOCK)) < 0) {