From patchwork Thu Jul 25 13:09:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregor Jasny X-Patchwork-Id: 19399 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1V2LJa-0006u4-QA; Thu, 25 Jul 2013 15:10:42 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1V2LJY-000463-m2; Thu, 25 Jul 2013 15:10:42 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755820Ab3GYNKj (ORCPT + 1 other); Thu, 25 Jul 2013 09:10:39 -0400 Received: from mail-bk0-f42.google.com ([209.85.214.42]:55312 "EHLO mail-bk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755728Ab3GYNKh (ORCPT ); Thu, 25 Jul 2013 09:10:37 -0400 Received: by mail-bk0-f42.google.com with SMTP id jk13so689267bkc.29 for ; Thu, 25 Jul 2013 06:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=WFmIGAVBKmG80jUP4IDIs46xUbJ6WbT1464S4X4794Y=; b=Qac7ttViX0c50hcIt+K2DF77OUTDnou/+HlQlbFkiGpLSFCghXTnM0PjYk4+yKkvM3 QCoYG8p81Bt3lcLKb/DWrWbDk4kP+qjNJJezRUCzQ/CuJL4Wf2hbQ1rk2BHBkI1uVE2L v8Z5PU2W6jSmJ/jkOAcU+c3iTBhvzOAmTLf1OD+FHToUNNQi7X9h5HIzu+A8w0Dva+Ll NBleUlN03yNYEMuSHkAzinsX55VIUof7/f9LKK0DQzGxTKr36kpA28VLfltwUtoigkeN SK8j7Nk15t+T1A+a61jIG2zY4dOK6kE7i1w+7imiCR75XS5TDKfDj9r7pUHW4/nB+urK acLg== X-Received: by 10.204.230.71 with SMTP id jl7mr6273781bkb.72.1374757836215; Thu, 25 Jul 2013 06:10:36 -0700 (PDT) Received: from gjasny06.drs.expertcity.com ([78.108.113.8]) by mx.google.com with ESMTPSA id eu16sm10949773bkc.0.2013.07.25.06.10.35 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Jul 2013 06:10:35 -0700 (PDT) From: Gregor Jasny To: linux-media@vger.kernel.org Cc: Gregor Jasny , Mauro Carvalho Chehab Subject: [PATCH 2/4] libdvbv5: Fix reallocation in parse_lcn Date: Thu, 25 Jul 2013 15:09:32 +0200 Message-Id: <1374757774-29051-3-git-send-email-gjasny@googlemail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1374757774-29051-1-git-send-email-gjasny@googlemail.com> References: <1374757774-29051-1-git-send-email-gjasny@googlemail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.7.25.130016 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Detected by Coverity. Signed-off-by: Gregor Jasny CC: Mauro Carvalho Chehab --- lib/libdvbv5/descriptors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libdvbv5/descriptors.c b/lib/libdvbv5/descriptors.c index 73338d8..99d8fa3 100644 --- a/lib/libdvbv5/descriptors.c +++ b/lib/libdvbv5/descriptors.c @@ -758,7 +758,7 @@ static void parse_lcn(struct nit_table *nit_table, for (i = 0; i < dlen; i+= 4, p+= 4) { struct lcn_table **lcn = &nit_table->lcn; - *lcn = realloc(*lcn, (n + 1) * sizeof(*lcn)); + *lcn = realloc(*lcn, (n + 1) * sizeof(**lcn)); (*lcn)[n].service_id = p[0] << 8 | p[1]; (*lcn)[n].lcn = (p[2] << 8 | p[3]) & 0x3ff; nit_table->lcn_len++;