From patchwork Thu Jul 25 13:09:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregor Jasny X-Patchwork-Id: 19401 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1V2LJY-0006tN-Qe; Thu, 25 Jul 2013 15:10:40 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1V2LJW-000463-mC; Thu, 25 Jul 2013 15:10:40 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755695Ab3GYNKh (ORCPT + 1 other); Thu, 25 Jul 2013 09:10:37 -0400 Received: from mail-bk0-f42.google.com ([209.85.214.42]:55000 "EHLO mail-bk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755642Ab3GYNKg (ORCPT ); Thu, 25 Jul 2013 09:10:36 -0400 Received: by mail-bk0-f42.google.com with SMTP id jk13so679640bkc.1 for ; Thu, 25 Jul 2013 06:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=U647F3GdIJKUaNMszeDHCs3D9b4f+1p45M5qD42n9IU=; b=Pr0WgfP5PAoVHC7BkE/2Xe0a/5KtUHiHyUIunakpVwUN30zHetR1a8a1vrt4CJdBTE YrJ8E/vBQ24rtRoaANtgYr+rhEL9VMRknl0SAWHrsZlsSpr25tjwnjB7i7fw9+jcxZEX bxDu03HTzDxkA246xfIqMmy5O8mYK7J/irKmU7smsAzIfKgMlkxoAWsul2ylHtmdWp0Z b4zYAEggWBHnUZRcYsAbt1ieU0NE3xxL75w6kSfFKBXnf8ycowoSUzUc6OUdLyHASSy1 JjWqg206tO4Yxftmob7E/Am0k0DBaVx3B1ZtQlEJSEKJe81d+zGJUphnp5N+5iGNJf8u 1wfA== X-Received: by 10.205.116.1 with SMTP id fg1mr6238094bkc.169.1374757835119; Thu, 25 Jul 2013 06:10:35 -0700 (PDT) Received: from gjasny06.drs.expertcity.com ([78.108.113.8]) by mx.google.com with ESMTPSA id eu16sm10949773bkc.0.2013.07.25.06.10.33 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Jul 2013 06:10:34 -0700 (PDT) From: Gregor Jasny To: linux-media@vger.kernel.org Cc: Gregor Jasny , Mauro Carvalho Chehab Subject: [PATCH 1/4] xc3082: Fix use after free in free_firmware() Date: Thu, 25 Jul 2013 15:09:31 +0200 Message-Id: <1374757774-29051-2-git-send-email-gjasny@googlemail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1374757774-29051-1-git-send-email-gjasny@googlemail.com> References: <1374757774-29051-1-git-send-email-gjasny@googlemail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.7.25.130016 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Detected by Coverity Scanner. CC: Mauro Carvalho Chehab Signed-off-by: Gregor Jasny --- utils/xc3028-firmware/firmware-tool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/xc3028-firmware/firmware-tool.c b/utils/xc3028-firmware/firmware-tool.c index b2e9de4..a7850df 100644 --- a/utils/xc3028-firmware/firmware-tool.c +++ b/utils/xc3028-firmware/firmware-tool.c @@ -86,13 +86,13 @@ static struct firmware* alloc_firmware(void) { static void free_firmware(struct firmware *f) { free(f->name); - free(f->desc); if(f->desc) { unsigned int i = 0; for(i = 0; i < f->nr_desc; ++ i) { free(f->desc[i].data); } } + free(f->desc); free(f); }