From patchwork Sat Jul 20 18:48:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 19343 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1V0cDT-0006xF-NZ; Sat, 20 Jul 2013 20:49:15 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1V0cDR-0007gJ-9X; Sat, 20 Jul 2013 20:49:15 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754739Ab3GTStI (ORCPT + 1 other); Sat, 20 Jul 2013 14:49:08 -0400 Received: from mail-ye0-f174.google.com ([209.85.213.174]:36342 "EHLO mail-ye0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754723Ab3GTStH (ORCPT ); Sat, 20 Jul 2013 14:49:07 -0400 Received: by mail-ye0-f174.google.com with SMTP id m9so1639525yen.33 for ; Sat, 20 Jul 2013 11:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=92wtv0mtTveHIKcPmIMiBy5l+PKQIaRPBsRMtEq/srg=; b=WYuMtYZY/t1geRh+D7v4VxgNsZTEw+00fCCA9bbckABWGrZO4rzpP9NxYl9rGURDpv S2/pdmAdZuOZVU8AUAWQUpVxGo0qkS1UgglCRwFrLUFypGvQwpWeEBoudDZaF8zX+Bfo x3oanIlkDkj+9wrv41z/E4PKUJzLeO+5+gNc+BwkdDtzkGpq2WSznfkla8vscMGHXgKF 8yjUZ9yTt1D2OrrN1wNJ4Y6FVaKQpsRNoVxeu9JpRQUCHTqTTwMB3kJncr8/PSsqBNu4 wHt7DUxvbzUy+j6ikDq9Ri+FHarZ1KSMSsdhA6dfEljwAOwxZapYDBqVcPBmG6WBGWrH L64A== X-Received: by 10.236.104.162 with SMTP id i22mr11226819yhg.193.1374346146891; Sat, 20 Jul 2013 11:49:06 -0700 (PDT) Received: from localhost.localdomain ([189.5.19.145]) by mx.google.com with ESMTPSA id v68sm29205765yhn.22.2013.07.20.11.49.05 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 20 Jul 2013 11:49:06 -0700 (PDT) From: Fabio Estevam To: k.debski@samsung.com Cc: m.chehab@samsung.com, kernel@pengutronix.de, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH 1/2] [media] coda: Check the return value from clk_prepare_enable() Date: Sat, 20 Jul 2013 15:48:48 -0300 Message-Id: <1374346129-12907-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.7.20.183931 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Fabio Estevam clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index df4ada88..dd76228 100644 --- a/drivers/media/platform/coda.c +++ b/drivers/media/platform/coda.c @@ -1559,14 +1559,20 @@ static int coda_open(struct file *file) list_add(&ctx->list, &dev->instances); coda_unlock(ctx); - clk_prepare_enable(dev->clk_per); - clk_prepare_enable(dev->clk_ahb); + ret = clk_prepare_enable(dev->clk_per); + if (ret) + goto err; + + ret = clk_prepare_enable(dev->clk_ahb); + goto err_clk_ahb; v4l2_dbg(1, coda_debug, &dev->v4l2_dev, "Created instance %d (%p)\n", ctx->idx, ctx); return 0; +err_clk_ahb: + clk_disable_unprepare(dev->clk_per); err: v4l2_fh_del(&ctx->fh); v4l2_fh_exit(&ctx->fh);