From patchwork Thu Jul 18 01:33:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Alves X-Patchwork-Id: 19304 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Uzd64-0006Zx-Ok; Thu, 18 Jul 2013 03:33:32 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1Uzd62-0002cq-6D; Thu, 18 Jul 2013 03:33:32 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964944Ab3GRBd2 (ORCPT + 1 other); Wed, 17 Jul 2013 21:33:28 -0400 Received: from mail-we0-f171.google.com ([74.125.82.171]:60625 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964871Ab3GRBd2 (ORCPT ); Wed, 17 Jul 2013 21:33:28 -0400 Received: by mail-we0-f171.google.com with SMTP id m46so2397936wev.16 for ; Wed, 17 Jul 2013 18:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=zK9Q9quxntEK8X5emPBn977rcSg6B8N1wJ0TvM9arjA=; b=P9DcDl2A6joaCb5lhd269xOGulkgnW8iVZZydUuFFjHrbNf5AhvkVQOsndGJ7vovfb 8HgVoNKTsawxHMPawDvWTYL8+hCGBhmjC+NJsCwBv2YR0vbAtWLa7OK1gmzmfTpyVCAY Z31+aFOO8C046NLTt94adNvb8kUGLYCwCF3jI/IO46oQoZG30QGWcaJfYDJQcV7kXfn2 6KsSRdpnAbRDNPLhMrcSGhoTh2EbkM0Mh23/DTCw4IfKNSCgvgQrMhUZa8F10P/U566k 4u774+weraT5xybM+bAh/NXytXNQpJ346QO3Hxu2GEW2oLLmNY3bdfWkjFLiiNfBLtrY PWOA== X-Received: by 10.180.81.169 with SMTP id b9mr17533269wiy.40.1374111207065; Wed, 17 Jul 2013 18:33:27 -0700 (PDT) Received: from xsys-lnx.lan (a89-152-208-145.cpe.netcabo.pt. [89.152.208.145]) by mx.google.com with ESMTPSA id h8sm13301166wie.1.2013.07.17.18.33.25 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 17 Jul 2013 18:33:26 -0700 (PDT) From: Luis Alves To: linux-media@vger.kernel.org Cc: mchehab@infradead.org, crope@iki.fi, awalls@md.metrocast.net, Luis Alves Subject: [PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled. Date: Thu, 18 Jul 2013 02:33:22 +0100 Message-Id: <1374111202-23288-1-git-send-email-ljalvs@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.7.18.12137 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1900_1999 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Hi, This i2c init should stop the interrupt storm that happens in some cards when the IR receiver in enabled. It works perfectly in my TBS6981. It would be good to test in other problematic cards. In this patch I've added the IR init to the TeVii S470/S471 (and some others that fall in the same case statment). Other cards but these that suffer the same issue should also be tested. Give feedback! Regards, Luis Signed-off-by: Luis Alves --- drivers/media/pci/cx23885/cx23885-cards.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/media/pci/cx23885/cx23885-cards.c b/drivers/media/pci/cx23885/cx23885-cards.c index 7e923f8..89ce132 100644 --- a/drivers/media/pci/cx23885/cx23885-cards.c +++ b/drivers/media/pci/cx23885/cx23885-cards.c @@ -1081,6 +1081,27 @@ int cx23885_tuner_callback(void *priv, int component, int command, int arg) return 0; } +void cx23885_ir_setup(struct cx23885_dev *dev) +{ + struct i2c_msg msg; + char buffer[2]; + + /* this should stop the IR interrupt + storm that happens in some cards */ + msg.addr = 0x4c; + msg.flags = 0; + msg.len = 2; + msg.buf = buffer; + + buffer[0] = 0x1f; + buffer[1] = 0x80; + i2c_transfer(&dev->i2c_bus[2].i2c_adap, &msg, 1); + + buffer[0] = 0x23; + buffer[1] = 0x80; + i2c_transfer(&dev->i2c_bus[2].i2c_adap, &msg, 1); +} + void cx23885_gpio_setup(struct cx23885_dev *dev) { switch (dev->board) { @@ -1664,6 +1685,7 @@ void cx23885_card_setup(struct cx23885_dev *dev) ts1->gen_ctrl_val = 0x5; /* Parallel */ ts1->ts_clk_en_val = 0x1; /* Enable TS_CLK */ ts1->src_sel_val = CX23885_SRC_SEL_PARALLEL_MPEG_VIDEO; + cx23885_ir_setup(dev); break; case CX23885_BOARD_NETUP_DUAL_DVBS2_CI: case CX23885_BOARD_NETUP_DUAL_DVB_T_C_CI_RF: