From patchwork Thu Jul 11 16:02:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Alves X-Patchwork-Id: 19252 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UxJKf-0008M2-VG; Thu, 11 Jul 2013 18:03:02 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1UxJKd-0003vf-1u; Thu, 11 Jul 2013 18:03:01 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932167Ab3GKQC5 (ORCPT + 1 other); Thu, 11 Jul 2013 12:02:57 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:35260 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755735Ab3GKQC5 (ORCPT ); Thu, 11 Jul 2013 12:02:57 -0400 Received: by mail-wg0-f41.google.com with SMTP id y10so12140266wgg.4 for ; Thu, 11 Jul 2013 09:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=pQ+tATFsu+wemI4PnB0MK+ga4yB+uFE4gVU5fGGuAWM=; b=Dkgm/aIrRtfap/MrQt0Esi6BntzNtEGTvr/DGLcVuXdpzjfZk3e3JnGRQ6iLNd3EVb XpYe1C6pxxGUu7qmCP3I37TPwHa69X3DLYikcAEZP6hd/miP7EXXUyhIiplDqRPK349/ cTMEJLN6+YKoYa7WjUZA/isj+Y6mL7uqHGP61f3GeNHiB/b58N2RjB8TRuLWEPjLXTTv rcI9d+5LiPX5yiZ+9BisEDRQWt6Hv8Eg5oTJ/NE0FND86mwMT0nQya7ZOLCM/iQvQei1 GMqcgSW0sTXRsz/leRhPKYW//RRrFtfzLi/zSz1CINZPbqwEDHkkrQlr89U6oa6M7EwP HJAA== X-Received: by 10.180.8.170 with SMTP id s10mr4784766wia.21.1373558575845; Thu, 11 Jul 2013 09:02:55 -0700 (PDT) Received: from xsys-lnx.lan (a89-152-208-145.cpe.netcabo.pt. [89.152.208.145]) by mx.google.com with ESMTPSA id o10sm43141197wiz.5.2013.07.11.09.02.52 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 11 Jul 2013 09:02:54 -0700 (PDT) From: Luis Alves To: linux-media@vger.kernel.org Cc: mchehab@infradead.org, crope@iki.fi, Luis Alves Subject: [PATCH] Fixed misleading error when handling IR interrupts. Date: Thu, 11 Jul 2013 17:02:44 +0100 Message-Id: <1373558564-14968-1-git-send-email-ljalvs@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.7.11.155420 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Hi, Handling the AV Core/IR interrupts schedules its workqueue but the schedule_work function returns false if @work was already on the kernel-global workqueue and true otherwise. Printing an error message if @work wasn't in the queue is wrong. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/pci/cx23885/cx23885-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-core.c b/drivers/media/pci/cx23885/cx23885-core.c index 268654a..9f63d93 100644 --- a/drivers/media/pci/cx23885/cx23885-core.c +++ b/drivers/media/pci/cx23885/cx23885-core.c @@ -1941,10 +1941,7 @@ static irqreturn_t cx23885_irq(int irq, void *dev_id) if ((pci_status & pci_mask) & PCI_MSK_AV_CORE) { cx23885_irq_disable(dev, PCI_MSK_AV_CORE); - if (!schedule_work(&dev->cx25840_work)) - printk(KERN_ERR "%s: failed to set up deferred work for" - " AV Core/IR interrupt. Interrupt is disabled" - " and won't be re-enabled\n", dev->name); + schedule_work(&dev->cx25840_work); handled++; }