From patchwork Sat May 25 11:25:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 18514 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UgCdK-0006H1-W4; Sat, 25 May 2013 13:27:35 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1UgCdI-00023H-m8; Sat, 25 May 2013 13:27:34 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754881Ab3EYL1b (ORCPT + 1 other); Sat, 25 May 2013 07:27:31 -0400 Received: from mail-bk0-f47.google.com ([209.85.214.47]:37649 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754195Ab3EYL1a (ORCPT ); Sat, 25 May 2013 07:27:30 -0400 Received: by mail-bk0-f47.google.com with SMTP id jg1so2892621bkc.20 for ; Sat, 25 May 2013 04:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=UWjcAy6RSvXvYv/FYKxjjgxsrWVRm4l+//udyDZp7f0=; b=dorYM0a+kd6v17AMKfK7nQLfG0qgRBURvB8/ngsQsNGkxjQg2VWXbhYmZ6R/7y3bxi qhVq40TbFxEr2/rnL325sl89NpMK996uuwUEAg34QkO2T4vAtaJjo61ER7jNeGDuRerr olprb5WkvzxcNn9AvJZZS4SvGUgIxcWmPe3d253gZyJyuqmj7fywpPImAfCP5KBSdqH2 Vo8Uh31jxBMYx+rRUb2yMVXhDPlqxEhodXKibYVC9VSQjjGFH+5VFxadSjSJ+nzJob2r 8i5YPSEfAAv+SlB7CHdL6tq2t3njc9jO89JWNzp+iLUJ4z4m66v35v0akc45ZoD/QZ6K WMzQ== X-Received: by 10.204.116.69 with SMTP id l5mr1077328bkq.163.1369481249424; Sat, 25 May 2013 04:27:29 -0700 (PDT) Received: from localhost.localdomain (093105185086.warszawa.vectranet.pl. [93.105.185.86]) by mx.google.com with ESMTPSA id b12sm5522266bkz.0.2013.05.25.04.27.27 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 25 May 2013 04:27:28 -0700 (PDT) From: Sylwester Nawrocki To: linux-media@vger.kernel.org Cc: a.hajda@samsung.com, arun.kk@samsung.com, k.debski@samsung.com, t.stanislaws@samsung.com, Sylwester Nawrocki Subject: [PATCH 3/5] s5p-tv: Do not ignore regulator/clk API return values in sdo_drv.c Date: Sat, 25 May 2013 13:25:53 +0200 Message-Id: <1369481155-30446-4-git-send-email-sylvester.nawrocki@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1369481155-30446-1-git-send-email-sylvester.nawrocki@gmail.com> References: <1369481155-30446-1-git-send-email-sylvester.nawrocki@gmail.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.5.25.111818 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' This patch fixes following compilation warning: drivers/media/platform/s5p-tv/sdo_drv.c: In function ‘sdo_runtime_resume’: drivers/media/platform/s5p-tv/sdo_drv.c:268:18: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result drivers/media/platform/s5p-tv/sdo_drv.c:269:18: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result Cc: Tomasz Stanislawski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-tv/sdo_drv.c | 22 +++++++++++++++++++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c b/drivers/media/platform/s5p-tv/sdo_drv.c index ab6f9ef..0afa90f 100644 --- a/drivers/media/platform/s5p-tv/sdo_drv.c +++ b/drivers/media/platform/s5p-tv/sdo_drv.c @@ -262,11 +262,21 @@ static int sdo_runtime_resume(struct device *dev) { struct v4l2_subdev *sd = dev_get_drvdata(dev); struct sdo_device *sdev = sd_to_sdev(sd); + int ret; dev_info(dev, "resume\n"); - clk_enable(sdev->sclk_dac); - regulator_enable(sdev->vdac); - regulator_enable(sdev->vdet); + + ret = clk_enable(sdev->sclk_dac); + if (ret < 0) + return ret; + + ret = regulator_enable(sdev->vdac); + if (ret < 0) + goto dac_clk_dis; + + ret = regulator_enable(sdev->vdet); + if (ret < 0) + goto vdac_r_dis; /* software reset */ sdo_write_mask(sdev, SDO_CLKCON, ~0, SDO_TVOUT_SW_RESET); @@ -285,6 +295,12 @@ static int sdo_runtime_resume(struct device *dev) SDO_COMPENSATION_CVBS_COMP_OFF); sdo_reg_debug(sdev); return 0; + +vdac_r_dis: + regulator_disable(sdev->vdac); +dac_clk_dis: + clk_disable(sdev->sclk_dac); + return ret; } static const struct dev_pm_ops sdo_pm_ops = {