From patchwork Sat May 25 11:25:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 18513 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UgCd7-0006Gd-NM; Sat, 25 May 2013 13:27:21 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1UgCd5-00021v-lN; Sat, 25 May 2013 13:27:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755597Ab3EYL1R (ORCPT + 1 other); Sat, 25 May 2013 07:27:17 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:64519 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754244Ab3EYL1R (ORCPT ); Sat, 25 May 2013 07:27:17 -0400 Received: by mail-bk0-f46.google.com with SMTP id my13so2941504bkb.5 for ; Sat, 25 May 2013 04:27:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=8LEy4jkOfVdL4NL3Oa7rarGHYp1cf5UpboJPFQGRhyc=; b=sAMWwM7M5omtRFbqNlVkOTILdJq3EP2rRbVckOPF+LOUy/WQ5yBwCXbGj5is3txHDM HPz2GSFTQpJKwvTsJwNjZHlWRGlVDoyHE+9RnqdIYS3tcgDYDfALW/+UutSQhxwIiIUN tLaiRc7idA/YXZlT6MXQqCJjMX2A/M2xss5MyAegRwQKVHJCO7ud+wKBFOzsriCqK5Te V9QszXRrlhlEY1pRzF2UheUf+vYdkC/JMmj52j3nP91a0aicb7IXVMA/EG3Y02/v8+pO tSAOpdbICYp2UeGQQBBL6k4BOsOvt94YwQgVD7dtcy+75CNjNYA868yuJo2i1YAikWDd Qtlw== X-Received: by 10.204.74.138 with SMTP id u10mr10284596bkj.113.1369481236055; Sat, 25 May 2013 04:27:16 -0700 (PDT) Received: from localhost.localdomain (093105185086.warszawa.vectranet.pl. [93.105.185.86]) by mx.google.com with ESMTPSA id b12sm5522266bkz.0.2013.05.25.04.27.13 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 25 May 2013 04:27:15 -0700 (PDT) From: Sylwester Nawrocki To: linux-media@vger.kernel.org Cc: a.hajda@samsung.com, arun.kk@samsung.com, k.debski@samsung.com, t.stanislaws@samsung.com, Sylwester Nawrocki Subject: [PATCH 2/5] s5p-tv: Don't ignore return value of regulator_enable() in sii9234_drv.c Date: Sat, 25 May 2013 13:25:52 +0200 Message-Id: <1369481155-30446-3-git-send-email-sylvester.nawrocki@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1369481155-30446-1-git-send-email-sylvester.nawrocki@gmail.com> References: <1369481155-30446-1-git-send-email-sylvester.nawrocki@gmail.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.5.25.111818 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' This patch fixes following compilation warning: CC [M] drivers/media/platform/s5p-tv/sii9234_drv.o drivers/media/platform/s5p-tv/sii9234_drv.c: In function ‘sii9234_runtime_resume’: drivers/media/platform/s5p-tv/sii9234_drv.c:252:18: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result Cc: Tomasz Stanislawski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-tv/sii9234_drv.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-tv/sii9234_drv.c b/drivers/media/platform/s5p-tv/sii9234_drv.c index 39b77d2..3dd762e 100644 --- a/drivers/media/platform/s5p-tv/sii9234_drv.c +++ b/drivers/media/platform/s5p-tv/sii9234_drv.c @@ -249,7 +249,9 @@ static int sii9234_runtime_resume(struct device *dev) int ret; dev_info(dev, "resume start\n"); - regulator_enable(ctx->power); + ret = regulator_enable(ctx->power); + if (ret < 0) + return ret; ret = sii9234_reset(ctx); if (ret)