From patchwork Mon May 13 09:24:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 18394 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UbpDG-0001Ao-JY; Mon, 13 May 2013 11:38:34 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1UbpCl-0004pt-k6; Mon, 13 May 2013 11:38:19 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709Ab3EMJhd (ORCPT + 1 other); Mon, 13 May 2013 05:37:33 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:57626 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120Ab3EMJhc (ORCPT ); Mon, 13 May 2013 05:37:32 -0400 Received: by mail-pb0-f42.google.com with SMTP id up7so4318378pbc.15 for ; Mon, 13 May 2013 02:37:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=3sZpwkdOHgRKCEPoNG7/GbbYgQ8xspOn/0rZkFOaHNg=; b=Rq+QF5AeZX93jAfxOb/y1UPzbElPe5eF8yn7X9jEEGnDFmhlpt2vHPtt2jH/9CfPRB DDl408IZK1s+jUFelkcMiUefsaEWRQrZ6FOgXzgpesPrKpWRhEvbziMbRyE5cH83be6s YQPEEGFuNjpTWcdg//UhK76+5AiCBkc672VH1byTFj60h+3Vm1ASVnedzXUp0Kcf6LNe E5D7mSFxepSdCFtgVy7R2jko5dUUDUedVsJ+qPGpkmSeF9PikSNhDoqk689JFBt74IxJ rNzoPM4yMEIs8xPEnWvROjb7eufXJXG+pwk/PxBb5gonLbbBGr0kNGJe5Lx3/4Qeufip TCYA== X-Received: by 10.66.230.228 with SMTP id tb4mr3295891pac.160.1368437852115; Mon, 13 May 2013 02:37:32 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id rn7sm2470016pbc.12.2013.05.13.02.37.29 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 13 May 2013 02:37:31 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: mchehab@redhat.com, sachin.kamat@linaro.org Subject: [PATCH 2/2] [media] rc: gpio-ir-recv: Remove redundant platform_set_drvdata() Date: Mon, 13 May 2013 14:54:08 +0530 Message-Id: <1368437048-13172-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1368437048-13172-1-git-send-email-sachin.kamat@linaro.org> References: <1368437048-13172-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQmXiu2K56b9TZa+J8ToDeW+h5MgzrQLQibDCKbP21lwBTB3Ty+2QD3S2R3sMG1o0C+RSFa8 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.5.13.92725 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- drivers/media/rc/gpio-ir-recv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c index 8b82ae9..07aacfa 100644 --- a/drivers/media/rc/gpio-ir-recv.c +++ b/drivers/media/rc/gpio-ir-recv.c @@ -178,7 +178,6 @@ static int gpio_ir_recv_probe(struct platform_device *pdev) return 0; err_request_irq: - platform_set_drvdata(pdev, NULL); rc_unregister_device(rcdev); rcdev = NULL; err_register_rc_device: @@ -196,7 +195,6 @@ static int gpio_ir_recv_remove(struct platform_device *pdev) struct gpio_rc_dev *gpio_dev = platform_get_drvdata(pdev); free_irq(gpio_to_irq(gpio_dev->gpio_nr), gpio_dev); - platform_set_drvdata(pdev, NULL); rc_unregister_device(gpio_dev->rcdev); gpio_free(gpio_dev->gpio_nr); kfree(gpio_dev);