From patchwork Mon May 13 09:24:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 18393 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UbpCl-0001AE-6U; Mon, 13 May 2013 11:38:03 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1UbpCO-0004pt-jz; Mon, 13 May 2013 11:37:50 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766Ab3EMJha (ORCPT + 1 other); Mon, 13 May 2013 05:37:30 -0400 Received: from mail-pb0-f49.google.com ([209.85.160.49]:62142 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531Ab3EMJh3 (ORCPT ); Mon, 13 May 2013 05:37:29 -0400 Received: by mail-pb0-f49.google.com with SMTP id rp2so1593249pbb.22 for ; Mon, 13 May 2013 02:37:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=xOsc1mJ6g+APdhPycM2Oy6OO+LyPkUxSuJ+RW5291FU=; b=bpXE3/O9rlZHgWtiuSp34zCbRLsxpnRpHxK2R0cyWsNDrwwhLJnRx0/cdZb9KAM+PS YXJZzEW4DpPyR3wKm/VaUriYyWIGejva59s4Ou2CQzpVlhqo0zYI1N702jXwHvTzH/GI lDkkLm9caQaaoO+FVwVeExUmuALSIOyecwiGuiJs24pA2jej5jVBbysy/QuG/0PUVLbD 8h6s9yAkrXZO/CnUv0NOQWYpHepCyhNhD2tGpNjhe+oIrWHrW2cgxNNbenWMeyg5fpsh mCXIje0T51AksJSc/3GEvWAk24372NxpW4ZExMhtHXjoI3vJzyAwtOAbUIJoIeTbwjl5 kdyg== X-Received: by 10.66.145.67 with SMTP id ss3mr29200322pab.18.1368437849090; Mon, 13 May 2013 02:37:29 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id rn7sm2470016pbc.12.2013.05.13.02.37.26 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 13 May 2013 02:37:28 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: mchehab@redhat.com, sachin.kamat@linaro.org, Pelagicore AB Subject: [PATCH 1/2] [media] timblogiw: Remove redundant platform_set_drvdata() Date: Mon, 13 May 2013 14:54:07 +0530 Message-Id: <1368437048-13172-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQnk+dcBXpfJb8otFhGeKOqJiFAdrMRdrst/kqHCBFLiNVVQVlLdryYphMQqiD97aU3TzUBS Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.5.13.92725 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Pelagicore AB --- drivers/media/platform/timblogiw.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/media/platform/timblogiw.c b/drivers/media/platform/timblogiw.c index a2f7bdd..99861c63 100644 --- a/drivers/media/platform/timblogiw.c +++ b/drivers/media/platform/timblogiw.c @@ -834,11 +834,9 @@ static int timblogiw_probe(struct platform_device *pdev) goto err_request; } - return 0; err_request: - platform_set_drvdata(pdev, NULL); v4l2_device_unregister(&lw->v4l2_dev); err_register: kfree(lw); @@ -858,8 +856,6 @@ static int timblogiw_remove(struct platform_device *pdev) kfree(lw); - platform_set_drvdata(pdev, NULL); - return 0; }