From patchwork Mon May 13 09:19:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 18392 X-Patchwork-Delegate: g.liakhovetski@gmx.de Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Ubp9i-0000ze-PT; Mon, 13 May 2013 11:34:54 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1Ubp9e-0000l6-02; Mon, 13 May 2013 11:34:51 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751652Ab3EMJco (ORCPT + 1 other); Mon, 13 May 2013 05:32:44 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:37083 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992Ab3EMJcn (ORCPT ); Mon, 13 May 2013 05:32:43 -0400 Received: by mail-pd0-f173.google.com with SMTP id v10so4290252pde.4 for ; Mon, 13 May 2013 02:32:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=0YN9wYIaXknyl2mFIX1xAIPQsyv5vyzsFQgZihnDFmc=; b=jVEZLOXsCsoq7m1rYjk/VRtmnBvvEJZlnyhJdaZ8f5G3oXSA1cRwVdrwH4JJI055Hw lCvakH1TuWlMIqI+DXptc9SBoDIWS3i76JSz8NTgNhulY7kEqZkqPNa1FJq/i5tE3WYY OHvYE2cqlHsIcpRsVrLbGewV9t/GmGWQNnBeuo0xS1fF2d7Wp1BufR8FxPCEnCejmh9w y5yZqgLD4xnCO9mCAvznuj3IMgkC5iFsGzK2sNqEv1Qz4oxZ2oD+GvyaumcOjqSigQy3 IGQFaWBwapcRuKDf/JO8jhqRcEFGA43jQGjWgkxIpvI6Ht7KY+yX4RnDQGhUNc3YeNWm 6eAg== X-Received: by 10.69.3.65 with SMTP id bu1mr28288136pbd.107.1368437563365; Mon, 13 May 2013 02:32:43 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id az5sm13367614pbc.18.2013.05.13.02.32.40 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 13 May 2013 02:32:42 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: g.liakhovetski@gmx.de, sachin.kamat@linaro.org Subject: [PATCH 2/2] [media] soc_camera_platform: Remove redundant platform_set_drvdata() Date: Mon, 13 May 2013 14:49:21 +0530 Message-Id: <1368436761-12183-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1368436761-12183-1-git-send-email-sachin.kamat@linaro.org> References: <1368436761-12183-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQnLPAnAgYUw/gdEXFUNu0TOP4oHQb+HDgIA7A7+ZXdGA+vu7s1RovBdZAKAMc0bJLRK/CV9 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.5.13.92725 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1400_1499 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- .../platform/soc_camera/soc_camera_platform.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c index 1b7a88c..bf0bdd0 100644 --- a/drivers/media/platform/soc_camera/soc_camera_platform.c +++ b/drivers/media/platform/soc_camera/soc_camera_platform.c @@ -166,14 +166,8 @@ static int soc_camera_platform_probe(struct platform_device *pdev) strncpy(priv->subdev.name, dev_name(&pdev->dev), V4L2_SUBDEV_NAME_SIZE); ret = v4l2_device_register_subdev(&ici->v4l2_dev, &priv->subdev); - if (ret) - goto evdrs; return ret; - -evdrs: - platform_set_drvdata(pdev, NULL); - return ret; } static int soc_camera_platform_remove(struct platform_device *pdev) @@ -183,7 +177,6 @@ static int soc_camera_platform_remove(struct platform_device *pdev) p->icd->control = NULL; v4l2_device_unregister_subdev(&priv->subdev); - platform_set_drvdata(pdev, NULL); return 0; }