From patchwork Tue Apr 30 06:16:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 18261 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UX43x-0005rO-4t; Tue, 30 Apr 2013 08:29:17 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1UX43u-0002hv-1g; Tue, 30 Apr 2013 08:29:16 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891Ab3D3G3M (ORCPT + 1 other); Tue, 30 Apr 2013 02:29:12 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:37775 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752680Ab3D3G3L (ORCPT ); Tue, 30 Apr 2013 02:29:11 -0400 Received: by mail-pd0-f176.google.com with SMTP id r10so127412pdi.7 for ; Mon, 29 Apr 2013 23:29:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=UiI9kd7M+U92xMyKNwKPljyzVl44aFjXIt5/KBCZpkI=; b=faPsnQhxuhGfnK5Y14m5QCQNmgONXiHv/G6NOufAk053gH/6tyFRcQMb20mQA3dKk7 aWZWe8eQVA3fO/wJGc9mFOm9/2sBBkO7a0yqJHxu/O8jY63Vw4BUdiS6NbuvrZRAfFzP +/oOGcyajStqxyPzvKGlSFnqieg9XZMnq4k0CqsZkABIp8U4Uq1jo8oPFmVVVyJgeWm0 GX7dcSqgheX10QGuUcElGbMCr9t3WreTF824wHeFBDYJp8uqKQ4zNTIady/2uozAvmcO KRVqPc1slTeNFxCi43HT3/wwVAEZTSN7h7A7MuBy8IA7biUveGcO1cpUFCTlKL1EFBSy Xsxg== X-Received: by 10.68.51.39 with SMTP id h7mr74738743pbo.155.1367303351293; Mon, 29 Apr 2013 23:29:11 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id lq5sm1934904pab.19.2013.04.29.23.29.08 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 23:29:10 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/4] [media] s3c-camif: Remove redundant NULL check Date: Tue, 30 Apr 2013 11:46:18 +0530 Message-Id: <1367302581-15478-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQn51Kcw0JgsgbTIqAvXopXelZNnI0CBYNKgguSxn6N7/8SX2zKuUcD+P5jMNYlFEmZfZTeH Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.4.30.61644 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' clk_unprepare checks for NULL pointer. Hence convert IS_ERR_OR_NULL to IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s3c-camif/camif-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c index 0d0fab1..2449f13 100644 --- a/drivers/media/platform/s3c-camif/camif-core.c +++ b/drivers/media/platform/s3c-camif/camif-core.c @@ -341,7 +341,7 @@ static void camif_clk_put(struct camif_dev *camif) int i; for (i = 0; i < CLK_MAX_NUM; i++) { - if (IS_ERR_OR_NULL(camif->clock[i])) + if (IS_ERR(camif->clock[i])) continue; clk_unprepare(camif->clock[i]); clk_put(camif->clock[i]);