From patchwork Tue Apr 30 04:51:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 18260 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UX2jr-00020c-Uh; Tue, 30 Apr 2013 07:04:27 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1UX2jp-0007QE-97; Tue, 30 Apr 2013 07:04:27 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751920Ab3D3FEY (ORCPT + 1 other); Tue, 30 Apr 2013 01:04:24 -0400 Received: from mail-da0-f53.google.com ([209.85.210.53]:59979 "EHLO mail-da0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549Ab3D3FEX (ORCPT ); Tue, 30 Apr 2013 01:04:23 -0400 Received: by mail-da0-f53.google.com with SMTP id n34so73904dal.40 for ; Mon, 29 Apr 2013 22:04:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=KT+QjdidIhxs9LtoMJw99nIKP1yjA3qfQ2X5jIAGGt0=; b=HRxWmZIzvCzrpxxLicEee8AQ/zXWVqRjsqi0m0vP2P1jJCvjOQIL+MyFjAgb5NDneY HkzjzmrUlksJcxch8SL4RKPzRIj8+CEwgdK9ILJ0QRvB1gmyS7VskyFD+fE2vFP5ycmv QkSs3Pwlk9qzY0KnhvqTbzk/Nc/4woDhVr6BzL/5T8Kn2O9nmtaMuj4Qac+olXq6LrMy xIDDiIGzwdLH/ar8sRPS0C8CTy+Lpsws6Crjp3b3KVCBe1Zw37iskAzZqDxMUOFOMiu4 5IEanq4qAhRTUFj9sEBSMToxbD+yhmQfMOkxgO/RPqJ89YbSyNFi+0UkStg8JqWzg4Ad Rs0g== X-Received: by 10.68.251.233 with SMTP id zn9mr8177420pbc.206.1367298262960; Mon, 29 Apr 2013 22:04:22 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id dr6sm28920440pac.11.2013.04.29.22.04.19 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 22:04:21 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] [media] exynos4-is: Remove redundant NULL check in fimc-lite.c Date: Tue, 30 Apr 2013 10:21:33 +0530 Message-Id: <1367297493-31782-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQkan5to9bOjv3ziEFlA17fkOV1aTnf8e9J0oevQpEBLDLkIQe6qHb+JEF4JqwhlAKuUbjEH Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.4.30.45417 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' clk_unprepare checks for NULL pointer. Hence convert IS_ERR_OR_NULL to IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-lite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c index 661d0d1..2a0ef82 100644 --- a/drivers/media/platform/exynos4-is/fimc-lite.c +++ b/drivers/media/platform/exynos4-is/fimc-lite.c @@ -1416,7 +1416,7 @@ static void fimc_lite_unregister_capture_subdev(struct fimc_lite *fimc) static void fimc_lite_clk_put(struct fimc_lite *fimc) { - if (IS_ERR_OR_NULL(fimc->clock)) + if (IS_ERR(fimc->clock)) return; clk_unprepare(fimc->clock);