From patchwork Mon Apr 29 09:24:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 18254 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UWkWz-0008I1-G2; Mon, 29 Apr 2013 11:37:57 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1UWkWx-00032O-58; Mon, 29 Apr 2013 11:37:57 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756875Ab3D2Jhx (ORCPT + 1 other); Mon, 29 Apr 2013 05:37:53 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:37587 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755678Ab3D2Jhx (ORCPT ); Mon, 29 Apr 2013 05:37:53 -0400 Received: by mail-pa0-f45.google.com with SMTP id lf10so3577365pab.18 for ; Mon, 29 Apr 2013 02:37:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=gTUMvatMIyuDhtQI9kOBlUF7q6cou88drkZxsdu/UgU=; b=gNcb067ZVcErNREs5FlTYhbYeuVJKNPkAN/SLEjPDI1KbZ5XVpW4KSjm2ZYufaltAU Vze9uFa4RGcVm48229a7irBmu7Z0LgDScgRyg+F5O+QPo/9FqfGlttVTLSatWhYZRFOH 5X79goB8KLf1Ru2TfvwSO4gBOS4OVD0PPU2G9FH7AtZydPLh0HdNrUpV0mITyGCIw599 3thH66vCkpVOx8FY8DpVKk+0tQqnLo8Kk52r51TP0XGOgXhSuwKD6RTL+8Jz4vwOgDx3 kHXemiLz0QHeLPTgR2/XLeYgtXbymfVSNaDBKt+IHd+B7p88mfPahROQVqsjAGjwdC7D gU+A== X-Received: by 10.68.137.168 with SMTP id qj8mr42685771pbb.17.1367228272531; Mon, 29 Apr 2013 02:37:52 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id br2sm23328203pbc.46.2013.04.29.02.37.49 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 02:37:52 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 3/3] [media] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in mixer_video.c Date: Mon, 29 Apr 2013 14:54:59 +0530 Message-Id: <1367227499-543-3-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1367227499-543-1-git-send-email-sachin.kamat@linaro.org> References: <1367227499-543-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQmx45dg9qEFqqlL1yRsP1UXVU3PRb0pCY1+ZwIogSufxIrBvN3/N5bSvliwfzRVh0Vqj/cJ Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.4.29.92718 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' vb2_dma_contig_init_ctx does not return NULL. Use IS_ERR() instead. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/mixer_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-tv/mixer_video.c b/drivers/media/platform/s5p-tv/mixer_video.c index ef0efdf..25319de 100644 --- a/drivers/media/platform/s5p-tv/mixer_video.c +++ b/drivers/media/platform/s5p-tv/mixer_video.c @@ -81,7 +81,7 @@ int mxr_acquire_video(struct mxr_device *mdev, } mdev->alloc_ctx = vb2_dma_contig_init_ctx(mdev->dev); - if (IS_ERR_OR_NULL(mdev->alloc_ctx)) { + if (IS_ERR(mdev->alloc_ctx)) { mxr_err(mdev, "could not acquire vb2 allocator\n"); goto fail_v4l2_dev; }